This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c1892e6c0fd4: Add virtual Scene::xrenderBufferPicture
method (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7207?vs=17897&id=17915
REVISION D
davidedmundson accepted this revision.
REPOSITORY
R108 KWin
BRANCH
scene-render-buffer
REVISION DETAIL
https://phabricator.kde.org/D7207
To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abet
graesslin updated this revision to Diff 17897.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Incorporated David's naming suggestion
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7207?vs=17895&id=17897
BRANCH
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> scene.h:164
> + **/
> +virtual xcb_render_picture_t bufferPicture() const;
> +
IMHO, as this class is generic, yet the return type is very speci
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
So far EffectsHandlerImpl directly accessed SceneXrender::bufferPicture
through a dynamic cast. If in future the XRender based composito
