D7260: System tray icon's context menu isn't updated properly in plasma/x11

kmaterka added a comment. Please check my comment in BUG 383202 . Problem is on Qt side and most probably can be solved there: QTBUG-79287 REPOSITORY

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. Any news on this bug and this change yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: broulik, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. > With this patch the "Bookmarks" menu in KWrite does no longer open (as if it were empty) with global menu enabled. Hmm, for some reason it still works for me. But when I use global menu, I see a small flickering: menu appears, hides and reappears. I assu

D7260: System tray icon's context menu isn't updated properly in plasma/x11

broulik added a comment. With this patch the "Bookmarks" menu in KWrite does no longer open (as if it were empty) with global menu enabled. In application F3903010: Screenshot_20170908_112004.png In global menu (affects both the plasmoid and the ti

D7260: System tray icon's context menu isn't updated properly in plasma/x11

cfeck added a comment. David, can you test again? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar updated this revision to Diff 18717. i.Dark_Templar added a comment. Updated patch for plasma-workspace 5.10, I'm using it with 5.10.4, but it should apply to master too. I've tried adding appmenu panel to desktop, still works fine for me. A bit of clarification. I'm not sure i

D7260: System tray icon's context menu isn't updated properly in plasma/x11

davidedmundson added a comment. > Did I miss something? One of us did. I did have to redo your patch manually as the diff here doesn't apply to either 5.10 or master. It's possible I did it wrong, maybe you can update it? The only difference is I did right click -> add panel ->

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. > That's not entirely true. We do show the cached version, but also immediately call aboutToShow which will update the subtree. In theory at least :) There's condition in function 'void DBusMenuImporter::slotAboutToShowDBusCallFinished(QDBusPendingCallWat

D7260: System tray icon's context menu isn't updated properly in plasma/x11

davidedmundson added a comment. I get that there's a bug - I'm not remotely suggesting we drop the issue. Your supplied test is really useful, it's valid and I do want to see this problem get fixed. But, we can't knowingly replace one bug with a different one, we don't improve anything

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. Current implementation is buggy. Cached menu items may be invalid: after 'LayoutUpdate' event updated menu all of it submenus are no longer valid (and thus cache contains invalid data) and should be updated. Menu itself is updated, but it's submenus are not. I

D7260: System tray icon's context menu isn't updated properly in plasma/x11

davidedmundson added a comment. We cache for a reason, simply removing the cache seems a hack for whatever the actual bug is. Deleting menus and recreating them causes big issues for the appmenu bar; as their we're displaying the menu widget. See comment on 1754c135c134e04d584d79e011a

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added reviewers: Plasma, davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lu

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a fix for a bug I recently reported at: https://bugs.kde.org/show_bug.cgi?id=383202 Basically, if you make system tray men