This revision was automatically updated to reflect the committed changes.
Closed by commit R134:dcae12f6b355: auto generate desktop file for url handling
(authored by sitter).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7343?vs=18224=18488
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Hmm... LGTM - mind that i am not the maintainer here, but it does look like
it's likely the needed approach.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
ltoscano added a comment.
In https://phabricator.kde.org/D7343#136271, @sitter wrote:
> @ltoscano is this file name change compatible from an i18n POV?
*.desktop.cmake files are processed like .desktop files also elsewhere, so
this should work.
REPOSITORY
R134 Discover
sitter reopened this revision.
sitter added a comment.
Blergh, reverted. Pushed in wrong terminal.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D7343
To: sitter, apol, ltoscano
Cc: ltoscano, plasma-devel, ZrenBot, progwolff, lesliezhai,
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:b433b503016e: auto generate desktop file for url handling
(authored by sitter).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7343?vs=18221=18224
sitter added a reviewer: ltoscano.
sitter added a subscriber: ltoscano.
sitter added a comment.
@ltoscano is this file name change compatible from an i18n POV?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D7343
To: sitter, apol, ltoscano
Cc:
sitter created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
configure_file on the desktop file to generate a NoDisplay variant to
handle URLs (currently appstream: only) and have the standard desktop
