D8146: Don't try to override label heights - PlasmaComponents

2017-10-05 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8146: Don't try to override label heights - PlasmaComponents

2017-10-05 Thread Marco Martin
mart added a comment. yes, this should stay. this was done in order to have labels automatically vertically align with other controls with just a Row (before RowLayout and Layout.alignment was a thing) as David says, will get rid of those once all is ported to new controls REPOSITORY

D8146: Don't try to override label heights - PlasmaComponents

2017-10-04 Thread David Edmundson
davidedmundson added a comment. I do hold a personal vendetta against this line, so I wish I could approve it. But, unlike the QQC2 change, PlasmaComponents.Label is pre-existing and used /everywhere/ . Not just within Plasma, but in literally every applet in the KDE store. I don't

D8146: Don't try to override label heights - PlasmaComponents

2017-10-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. nicolasfella added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Same as https://phabricator.kde.org/D8129 but