D8221: keyboard navigation in systemsettings

2017-10-17 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R124:1b904566ba66: keyboard navigation in systemsettings (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8221?vs=20892=20893#toc REPOSITORY R124 System Settings CHANGES SINCE

D8221: keyboard navigation in systemsettings

2017-10-17 Thread Marco Martin
mart updated this revision to Diff 20892. mart added a comment. - some hacks to improve keyboard navigation for QQuickWidget - focus search field on startup - Merge branch 'master' into randa/accessibility - some keybaord navigation fixes - correctly navigate between the two

D8221: keyboard navigation in systemsettings

2017-10-17 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > SidebarMode.cpp:525 > +if (fe->reason() == Qt::TabFocusReason) { > + > qqw->rootObject()->metaObject()->invokeMethod(qqw->rootObject(), > "focusFirstChild"); > +} else if (fe->reason() ==

D8221: keyboard navigation in systemsettings

2017-10-09 Thread Marco Martin
mart updated this revision to Diff 20518. mart added a comment. - activate items on space, enter and return REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8221?vs=20516=20518 BRANCH randa/accessibility REVISION DETAIL

D8221: keyboard navigation in systemsettings

2017-10-09 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY correct keyboard navigation in systemsettings, since there is a mix of qwidgets and QQuickWidgets, when a QQW takes focus, then the focus

D8221: keyboard navigation in systemsettings

2017-10-09 Thread Marco Martin
mart added a reviewer: Plasma. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8221 To: mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart