This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2ff7b3e22158: Set transient parent for system tray menus
(authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8338?vs=20888&id=2093
graesslin accepted this revision.
graesslin added inline comments.
INLINE COMMENTS
> apol wrote in systemtray.cpp:216
> This looks wrong...
nah, it's the common trick to create the windowHandle. Without the next line of
code would crash. Don't ask me why Qt doesn't have proper API for it...
RE
apol added inline comments.
INLINE COMMENTS
> systemtray.cpp:216
> KAcceleratorManager::manage(desktopMenu);
> +desktopMenu->winId();
> +
> desktopMenu->windowHandle()->setTransientParent(appletInterface->window());
This looks wrong...
REPOSITORY
R120 Plasma Workspace
BRANCH
m
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8338
To: davidedmundson, #plasma, mart
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensr
davidedmundson updated this revision to Diff 20888.
davidedmundson added a comment.
update
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8338?vs=20887&id=20888
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8338
AFFECTED FILES
davidedmundson updated this revision to Diff 20887.
davidedmundson added a comment.
Remove irrelevant code
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8338?vs=20880&id=20887
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8338
graesslin added a comment.
Looks good!
INLINE COMMENTS
> startplasma.cmake:31
> +Xft.dpi: $QT_WAYLAND_FORCE_DPI
> EOF
>
This looks unrelated.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8338
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel,
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 381174
TEST PLAN
Had debug in QtWayland
Clicked on systray
Had parent, menu was in
