bshah added a comment.
In https://phabricator.kde.org/D8344#158566, @graesslin wrote:
> Maybe there is no need to have that method static?
>
> Sorry about the build failure...
Yeah, going by that theory, will put patch in phab in moment.
REPOSITORY
R108 KWin
REVISION
graesslin added a comment.
In https://phabricator.kde.org/D8344#158553, @bshah wrote:
> > This breaks the build.. will fix it however.
>
> Tricky, the method using `m_physicalSize` is static method, would it cause
any issue if I make `m_physicalSize` also static?
Maybe there
bshah added a comment.
> This breaks the build.. will fix it however.
Tricky, the method using `m_physicalSize` is static method, would it cause
any issue if I make `m_physicalSize` also static?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8344
To: graesslin,
bshah added inline comments.
INLINE COMMENTS
> hwcomposer_backend.cpp:197
> static const qreal factor = 25.4;
> - o->setPhysicalSize(QSizeF(qreal(pixel.width() * 1000) /
> qreal(attr_values[2]) * factor,
> - qreal(pixel.height() * 1000) /
>
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:02d3daf28a47: Add physicalSize to the Screens API
(authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8344?vs=20911=20980#toc
REPOSITORY
R108 KWin
CHANGES SINCE LAST
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
screens-physical-size
REVISION DETAIL
https://phabricator.kde.org/D8344
To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
graesslin added a dependent revision: D8345: [QPA] Implement Screen on top of
internal Screens API.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8344
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening,
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Allows to share the implementation in a better way and is a requirement
to get the Screen
