D8526: add a background in ScrollView

This revision was automatically updated to reflect the committed changes. Closed by commit R858:e4e46ff4dbee: add a background in ScrollView (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22647=22648

D8526: add a background in ScrollView

mart updated this revision to Diff 22647. mart added a comment. - component can't be a child of scrollview REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22639=22647 BRANCH arcpatch-D8526_1 REVISION DETAIL

D8526: add a background in ScrollView

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Can you throw in a tonne of documentation explaining why things are being done the way they are. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH

D8526: add a background in ScrollView

mart updated this revision to Diff 22639. mart added a comment. fix fix and replace problems REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22638=22639 BRANCH arcpatch-D8526_1 REVISION DETAIL

D8526: add a background in ScrollView

mart marked 2 inline comments as done. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D8526: add a background in ScrollView

mart updated this revision to Diff 22638. mart added a comment. frame background REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=22637=22638 BRANCH arcpatch-D8526_1 REVISION DETAIL https://phabricator.kde.org/D8526

D8526: add a background in ScrollView

mart updated this revision to Diff 22637. mart added a comment. - create the background only after onCompleted REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8526?vs=21441=22637 BRANCH arcpatch-D8526_1 REVISION DETAIL

D8526: add a background in ScrollView

mart added a comment. tried a version which provides its own component in the kcm controls for the background problem, still not happy about it. https://phabricator.kde.org/D8692 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To:

D8526: add a background in ScrollView

mart added a comment. In https://phabricator.kde.org/D8526#168377, @davidedmundson wrote: > > so, may be worth to have in kirigami a component called like ItemScrollView intended for this? > > I think so. > The component can be just one line of ScrollView{}, and the styles can do

D8526: add a background in ScrollView

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > so, may be worth to have in kirigami a component called like ItemScrollView intended for this? I think so. The component can be just one line of

D8526: add a background in ScrollView

mart added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: mart, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8526: add a background in ScrollView

mart added a comment. so, may be worth to have in kirigami a component called like ItemScrollView intended for this? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: mart, #plasma Cc: davidedmundson, plasma-devel, ZrenBot,

D8526: add a background in ScrollView

davidedmundson added a comment. In general ++. The frame is useful for keyboard focus indication if nothing else. INLINE COMMENTS > ScrollView.qml:47 > +visible: false > +elementType: "edit" > + As in a textedit? The QQC1 code used "frame" which is semantically more

D8526: add a background in ScrollView

mart added a comment. F5452808: Spectacle.X20944.png REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8526 To: mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8526: add a background in ScrollView

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY add a background in scrollview similar to what qwidget's scrollviews do hide it by default since is not