D8529: Plasma change icons should exit after its work finished.

2018-01-06 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R119:60bc30083fe4: Plasma change icons should exit after its work finished. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D8529: Plasma change icons should exit after its work finished.

2018-01-05 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8529: Plasma change icons should exit after its work finished.

2018-01-04 Thread Xuetian Weng
xuetianweng added a comment. In https://phabricator.kde.org/D8529#186000, @broulik wrote: > Good to go, no? I have no problem with that. Any one have extra comment? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart,

D8529: Plasma change icons should exit after its work finished.

2018-01-04 Thread Kai Uwe Broulik
broulik added a comment. Good to go, no? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

2017-11-01 Thread Xuetian Weng
xuetianweng added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8529: Plasma change icons should exit after its work finished.

2017-10-30 Thread Xuetian Weng
xuetianweng added a comment. @mart I understand what you want to say, but for this specific case: https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037 rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done. And thus

D8529: Plasma change icons should exit after its work finished.

2017-10-30 Thread Marco Martin
mart added a comment. hmm, i feel it would be more correct to connect to the procedure finished and then quit the app? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8529: Plasma change icons should exit after its work finished.

2017-10-27 Thread Xuetian Weng
xuetianweng created this revision. xuetianweng added reviewers: apol, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Right now plasma-iconchanges may remains on the system after change the icon theme. TEST PLAN