D8567: Return the screen id for a screen name.

2017-11-01 Thread Andras Mantia
amantia updated this revision to Diff 21687. amantia added a comment. Remove unneeded changed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8567?vs=21686=21687 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8567 AFFECTED FILES

D8567: Return the screen id for a screen name.

2017-11-01 Thread Milian Wolff
mwolff added inline comments. INLINE COMMENTS > shellcorona.cpp:1161 > > -if (DesktopView* v = desktopForScreen(screen)) > +if (DesktopView* v = desktopForScreen(screen)) { > removeDesktop(v); now you can undo this hunk REPOSITORY R120 Plasma

D8567: Return the screen id for a screen name.

2017-11-01 Thread Andras Mantia
amantia updated this revision to Diff 21686. amantia added a comment. Emit the screenRemoved from within removeDesktop REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8567?vs=21683=21686 BRANCH master REVISION DETAIL

D8567: Return the screen id for a screen name.

2017-11-01 Thread Andras Mantia
amantia marked an inline comment as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8567 To: amantia, #plasma, ervin, dvratil, mlaurent, hein Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8567: Return the screen id for a screen name.

2017-11-01 Thread Milian Wolff
mwolff added inline comments. INLINE COMMENTS > shellcorona.cpp:1162 > removeDesktop(v); > +emit screenRemoved(m_screenPool->id(screen->name())); > +} shouldn't this be done from within `removeDesktop`? considering this duplicates the change above?

D8567: Return the screen id for a screen name.

2017-11-01 Thread Andras Mantia
amantia updated this revision to Diff 21683. amantia edited the summary of this revision. amantia added a comment. Emit the screenRemoved/screenAdded signals. This needs a small rename of an internal method. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D8567: Return the screen id for a screen name.

2017-10-31 Thread Aleix Pol Gonzalez
apol added subscribers: mart, apol. apol added a comment. This is specially interesting and it would be important to make it right. One of the features we lose in Wayland is that we know where to place each component. because of this number being 0 the primary screen, where the

D8567: Return the screen id for a screen name.

2017-10-31 Thread David Edmundson
davidedmundson added a comment. The only intended use is folderview, and there are some comments there about whether that's the right approach. I don't want to have this pushed before we agree on that. Other than that, code is fine. REPOSITORY R120 Plasma Workspace REVISION

D8567: Return the screen id for a screen name.

2017-10-31 Thread Kevin Ottens
ervin added a comment. Looks good to me, but I'm giving time for the Plasma team to see it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8567 To: amantia, #plasma, ervin, dvratil, mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8567: Return the screen id for a screen name.

2017-10-31 Thread Andras Mantia
amantia edited the summary of this revision. amantia added reviewers: Plasma, ervin, dvratil, mlaurent, hein. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8567 To: amantia, #plasma, ervin, dvratil, mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff,

D8567: Return the screen id for a screen name.

2017-10-31 Thread Andras Mantia
amantia created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8567 AFFECTED FILES shell/shellcorona.cpp