This revision was automatically updated to reflect the committed changes.
Closed by commit R108:59f7ed9c780a: [platforms/drm] Forward the mode changes to
the OutputInterface (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
drm-mode-to-output
REVISION DETAIL
https://phabricator.kde.org/D8578
To: graesslin, #kwin, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, kwin, ZrenBot,
graesslin added a dependent revision: D8602: [platforms/drm] Restore previous
mode if an atomic test fails.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8578
To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
graesslin updated this revision to Diff 21660.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Add guard
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8578?vs=21654=21660
BRANCH
drm-mode-to-output
REVISION
davidedmundson added inline comments.
INLINE COMMENTS
> drm_output.cpp:214
> setDpms(DpmsMode::On);
> if (!m_waylandOutput.isNull()) {
> delete m_waylandOutput.data();
This method is coded so that init() can be called twice.
Either:
- that's pointless, and this should just
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
While KWin gained support for changing modes it did not yet forward it
to the Wayland
