This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3ebdd64e6bbd: Optimize SortFilterModel role names
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8639?vs=21832&id=21966
R
broulik added inline comments.
INLINE COMMENTS
> mwolff wrote in datamodel.h:141
> why was that kf6 note there?
Probably someone added it who thought it could not be changed because you can't
for exported classes but this isn't.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
h
mwolff accepted this revision.
mwolff added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> datamodel.h:141
> protected:
> -int roleNameToId(const QString &name); //FIXME TODO KF6: This should
> have been const.
> +int roleNameToId(const QString &nam
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8639
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreut
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
- Reserve m_roleIds
- Avoid double lookup contains+value but use default value argume
