This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b40c0de099fc: When used by QML, only populate after
component is complete (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8723?vs=22083&
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8723
To: hein, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m
hein updated this revision to Diff 22083.
hein added a comment.
Fix review comments by David and Kai.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8723?vs=22078&id=22083
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8723
AFFEC
broulik added inline comments.
INLINE COMMENTS
> tasksmodel.h:814
>
> +void classBegin();
> +void componentComplete();
`override`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8723
To: hein, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel,
davidedmundson added a comment.
> I'm not super happy with this behavior change for C++ users,
I've seen other people export a subclass for QtQuick that sets the usedByQml
flag.
I love QQmlParserStatus so +1
INLINE COMMENTS
> tasksmodel.cpp:632
> {
> +qDebug() << usedByQml <<
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This introduces the use of QQmlParserStatus to delay populating
the model until all properties have been set, to avoid delegate
churn.
TasksMo
