D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

This revision was automatically updated to reflect the committed changes. Closed by commit R119:25c30932961e: Port launch feedback KCM to Qt Quick and implement VDG redesign (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8911?vs=23327=26636#toc REPOSITORY R119

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. I think it's about time to merge this in master REPOSITORY R119 Plasma Desktop BRANCH fixthediff REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc:

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Sorry for the noise. This is now ready from my end, except for this build warning: AutoMoc warning: "/home/eike/devel/src/kde/workspace/plasma-desktop/kcms/launch/launchfeedback.cpp" The file includes the moc file "launchfeedback.moc", but does not

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 23326. hein added a comment. Try to fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=23325=23326 BRANCH arcpatch-D8911 REVISION DETAIL https://phabricator.kde.org/D8911 AFFECTED FILES

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 23327. hein added a comment. Try again REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=23326=23327 BRANCH fixthediff REVISION DETAIL https://phabricator.kde.org/D8911 AFFECTED FILES

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Argh, I have no idea what happened to the diff ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: anthonyfieroni, mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 23325. hein added a comment. - Port to SimpleKCM as base item - Fix a crash REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=22828=23325 BRANCH arcpatch-D8911 REVISION DETAIL

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main.qml:30-39 > My personal note is not mandatory but this piece of code can be seen 2 times > in C++ part and 1 in QML. Can we add it on C++ part and called here too. I hear you, but IMHO it's not really worth it to get

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:30-39 > +function applyBusyCursorCurrentIndex() { > +if (kcm.busyCursorCurrentIndex == 0) { > +busyCursorDisabled.checked = true; > +} else if (kcm.busyCursorCurrentIndex == 1) { > +

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. > Given you're now familiar with this code, can you look through: Done. Two reassigned/retitled, one closed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Visually, it looks great to me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22828. hein added a comment. - Implement latest VDG mockup. This simplifies the UI from two seperate timeout settings to one, but in the config files we still have two. We write both, but the code needs to make a decision which one to read and show

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Updated screenshot: F5506081: Screenshot_20171123_231847.png Branch is re-pushed as well. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Thanks, will implement tomorrow! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: mmustac, ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. After a lot of design work in https://phabricator.kde.org/tag/vdg/, we all agreed on the following: F5502756: photo_2017-11-22_08-59-07.jpg REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Us https://phabricator.kde.org/tag/vdg/ folks did a bunch of design work today and all agreed on the following: F5501647: Option 10.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

abetts added a comment. **These are the good examples of what I think it should be:** TITLE [ ] Verb/action explanation TITLE [ ] verb/explanation **IF** [ ] verb/explanation **But never** Verb/Explanation [X ] Verb/Explanation [X ] verb/explanation

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

broulik added a comment. In https://phabricator.kde.org/D8911#170262, @hein wrote: > Updated screenshot: > > F5500694: Screenshot_20171121_174245.png According to KDE HIG a REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. I'm sorry @hein. I understand that this is pretty frustrating. Sometimes there's no substitute for seeing the actual implementation, I guess! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc:

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. The above exchange is seriously upsetting and frustrating to me. I implemented the VDG mockup, and now there's discussion about the design in my code review. Please get your act together and make sure the mockups are ready for implementing so the review process of code

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Also as discussed in the VDG room this morning, there's the open question of whether we actually need a launch feedback KCM or whether these settings should be in the Task Manager's own settings. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. 1. I think the labels with controls next to them need colons. It looks weird otherwise. 2. We should vertically align the labels and their controls, just like @mmustac showed. That looks radically better. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

mmustac added a comment. I don't know if I am allowed to write here, so sorry if not ... I just wanted to share my point of view (daily user). While the first screens look good for me, the second one here seems to be very restless and so I wondered if I should share what I would like to

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. In https://phabricator.kde.org/D8911#170032, @ngraham wrote: > Can you add "Fixes https://phabricator.kde.org/T7284; so this it will close that Maniphest task once this goes in? Will do when pushing. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Updated screenshot: F5500694: Screenshot_20171121_174245.png I have a question: As per the mockup, I have no colons after the labels. I'm not sure I like that. Thoughts? @abetts, @ngraham? REPOSITORY R119 Plasma

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22681. hein marked 3 inline comments as done. hein added a comment. Address all review comments. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=22634=22681 BRANCH kcm-redesign/launchfeedback REVISION

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein marked 3 inline comments as done. hein added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:69 > "Task Manager notification: [checkbox] Enable Task Manager notification" a > bit redundant and overly wordy. How about the following? > > "Task Manager notification: [checkbox]"

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

abetts added a comment. I am ok with that idea. I agree that it is redundant. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: ngraham, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added inline comments. INLINE COMMENTS > main.qml:69 > + > +text: i18n("Enable Task Manager notification") > + "Task Manager notification: [checkbox] Enable Task Manager notification" a bit redundant and overly wordy. How about the following? "Task Manager notification:

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

ngraham added a comment. Can you add "Resolves https://phabricator.kde.org/T7284; so this it will close that Maniphest task once this goes in? INLINE COMMENTS > main.qml:49 > + > +text: i18n("Startup indication timeout:") > +} As discussed on

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

mart added inline comments. INLINE COMMENTS > main.qml:26 > + > +Kirigami.ScrollablePage { > +id: root i would like to have a base component for this (which admittedly doesn't exists yet as i need beforehand to merge the cursrs stuff which introduced the kcm components) tough for now

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in launchfeedback.cpp:169 > how does plasmashell get notified about new TaskbarButtonSettings? KDirWatch on the rc file iirc Note the old business logic doesn't have any anything more there. REPOSITORY R119 Plasma Desktop

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Review comments: Some of those also apply to the fonts KCM rewrite I based this on, e.g. the broken bindings. Will fix tomorrow, thanks :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc:

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

davidedmundson added a comment. Your Messages.sh doesn't include qml (copy the code in Marco's mouse diff) - Given you're now familiar with this code, can you look through:

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a reviewer: abetts. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart, abetts Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. Screenshot: F5499384: Screenshot_20171120_194949.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein added a comment. This is on git as branch kcm-redesign/launchfeedback. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein updated this revision to Diff 22634. hein added a comment. Add missing package. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8911?vs=22633=22634 BRANCH kcm-redesign/launchfeedback REVISION DETAIL https://phabricator.kde.org/D8911

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

broulik added a comment. I don't see any QML files REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8911 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8911: Port launch feedback KCM to Qt Quick and implement VDG redesign

hein created this revision. hein added reviewers: Plasma, mart. Restricted Application added a project: Plasma. REVISION SUMMARY - Implements VDG mockup https://phabricator.kde.org/M112/364/ - But using "Task Manager" naming for consistency instead of "Taskbar" - Additional UI tweak of