D8916: QML port of fonts kcm

2018-01-23 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:24b960f92284: QML port of fonts kcm (authored by mart). CHANGED PRIOR TO COMMIT

D8916: QML port of fonts kcm

2017-11-24 Thread Marco Martin
mart updated this revision to Diff 22899. mart added a comment. - reparent the font dialog REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8916?vs=22888=22899 BRANCH kcm-redesign/fonts REVISION DETAIL https://phabricator.kde.org/D8916 AFFECTED

D8916: QML port of fonts kcm

2017-11-24 Thread Marco Martin
mart updated this revision to Diff 22888. mart added a comment. - port to new kcmcontrols REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8916?vs=22687=22888 BRANCH kcm-redesign/fonts REVISION DETAIL https://phabricator.kde.org/D8916 AFFECTED

D8916: QML port of fonts kcm

2017-11-22 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8916#170830, @mart wrote: > In https://phabricator.kde.org/D8916#170365, @ngraham wrote: > > > Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string

D8916: QML port of fonts kcm

2017-11-22 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8916#170365, @ngraham wrote: > Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string that doesn't have any meaning to most users)? i would really

D8916: QML port of fonts kcm

2017-11-21 Thread Nathaniel Graham
ngraham added a comment. Could we possibly take the opportunity to turn font anti-aliasing on by default instead of leaving it with "Vendor Default" (a string that doesn't have any meaning to most users)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916

D8916: QML port of fonts kcm

2017-11-21 Thread Marco Martin
mart added a comment. F5501237: Spectacle.n25430.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916 To: mart, #plasma, #vdg Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8916: QML port of fonts kcm

2017-11-21 Thread Nathaniel Graham
ngraham added a comment. Needs more screenshots! :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916 To: mart, #plasma, #vdg Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8916: QML port of fonts kcm

2017-11-21 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > hein wrote in main.qml:175 > This and similar bindings will break when the user changes the spinbox value, > so after a manual adjustment e.g. defaults() won't work any longer. It needs > a seperate Connections à la

D8916: QML port of fonts kcm

2017-11-21 Thread Marco Martin
mart edited the summary of this revision. mart added a task: T7244: Fonts (somewhere in branch). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8916 To: mart, #plasma, #vdg Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8916: QML port of fonts kcm

2017-11-21 Thread Marco Martin
mart updated this revision to Diff 22687. mart added a comment. - needssave only when settings actually changed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8916?vs=22663=22687 BRANCH kcm-redesign/fonts REVISION DETAIL

D8916: QML port of fonts kcm

2017-11-21 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > fonts.cpp:570 > +emit smallFontChanged(); > +setNeedsSave(true); > +} Instead of always setting this to true in a prop setter, you need to implement a method that checks whether the new value is actually different from the stored

D8916: QML port of fonts kcm

2017-11-20 Thread Nathaniel Graham
ngraham added a comment. Can you mark this as resolving https://phabricator.kde.org/T7244, so that task will be automatically closed when this goes in? FWIW, the list of all KCM redesign tasks can be found at https://phabricator.kde.org/tag/plasma_kcm_redesign/ REPOSITORY R119 Plasma

D8916: QML port of fonts kcm

2017-11-20 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY port the fonts kcm to QML, reviving an old branch. UI based upon https://phabricator.kde.org/M112/411/