davidedmundson abandoned this revision.
davidedmundson added a comment.
Somehow this went from "lets add a thing to ksmserver" to "lets split
ksmserver"
Abandoning for now. Will return with something more extreme. (maybe for 5.13
at this point)
REPOSITORY
R120 Plasma Workspace
REVISI
davidedmundson planned changes to this revision.
davidedmundson added a comment.
Yeah, I like that too.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8924
To: davidedmundson, #plasma
Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezha
graesslin added a comment.
I fail to see how option 3 would help. But I'm in favor of option 1.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8924
To: davidedmundson, #plasma
Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-
davidedmundson added a comment.
> On X11 ksmserver, on Wayland KWin?
In principle great. It was the other possible choice.
But this spawns a window, generally kwin is bad at having it's own windows,
so it might not be trivial.
I certainly don't want to go down the route of kwin hol
graesslin added a comment.
In https://phabricator.kde.org/D8924#170463, @apol wrote:
> > This creates a "slight" problem for Wayland as ksmserver is forced to
XCB. What do you think about doing it like with kscreenlocker? On X11
ksmserver, on Wayland KWin? Otherwise +1000 to this suggest
apol added a comment.
> This creates a "slight" problem for Wayland as ksmserver is forced to XCB.
What do you think about doing it like with kscreenlocker? On X11 ksmserver, on
Wayland KWin? Otherwise +1000 to this suggestion.
Isn't the solution to stop forcing ksmserver to XCB?
REPOSI
graesslin added a comment.
This creates a "slight" problem for Wayland as ksmserver is forced to XCB.
What do you think about doing it like with kscreenlocker? On X11 ksmserver, on
Wayland KWin? Otherwise +1000 to this suggestion.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https:/
apol added a comment.
+1 for having it all in once place.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8924
To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The rationale is two-fold:
1. It fixes a security issue.
Right now, a rogue app can k