This revision was automatically updated to reflect the committed changes.
Closed by commit R858:d0e3daafdbdd: determine QQC2 version at build time
(authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9021?vs=23036=23120#toc
REPOSITORY
R858 Qt Quick Controls 2: Desktop
apol accepted this revision.
apol added a comment.
Okay, maybe it's not important...
INLINE COMMENTS
> CMakeLists.txt:4
> set(KF5_VERSION "5.41.0") # handled by release scripts
> -set(KF5_DEP_VERSION "5.40.0") # handled by release scripts
> +set(KF5_DEP_VERSION "5.39.0") # handled by
mart added a comment.
In https://phabricator.kde.org/D9021#172905, @apol wrote:
> In https://phabricator.kde.org/D9021#172842, @mart wrote:
>
> > could the ide always take info from a set theme, like the base "default"
one somehow?
>
>
> Well you are introducing some bit from a
apol added a comment.
In https://phabricator.kde.org/D9021#172842, @mart wrote:
> could the ide always take info from a set theme, like the base "default"
one somehow?
Well you are introducing some bit from a different language, so parsers won't
be able to process it ever.
mart added a comment.
In https://phabricator.kde.org/D9021#172748, @apol wrote:
> Note this breaks integration in the IDE.
>
> Is it maybe something to discuss with upstream?
could the ide always take info from a set theme, like the base "default" one
somehow?
REPOSITORY
apol added a comment.
Note this breaks integration in the IDE.
Is it maybe something to discuss with upstream?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
mart/autoversion
REVISION DETAIL
https://phabricator.kde.org/D9021
To: mart, #plasma, rizzitello,
rizzitello accepted this revision.
rizzitello added a comment.
This revision is now accepted and ready to land.
This removes the runtime problem referanced in the bug above.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
mart/autoversion
REVISION DETAIL
davidedmundson accepted this revision.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
mart/autoversion
REVISION DETAIL
https://phabricator.kde.org/D9021
To: mart, #plasma, rizzitello, davidedmundson
Cc: rizzitello, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mart updated this revision to Diff 23036.
mart added a comment.
- support editable for comboboxes
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9021?vs=23035=23036
BRANCH
mart/autoversion
REVISION DETAIL
mart updated this revision to Diff 23035.
mart added a comment.
- remove useless output
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9021?vs=23034=23035
BRANCH
mart/autoversion
REVISION DETAIL
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
the qqc2 theme style needs to import the same qqc2 version
than the latest one available in the installed Qt,
11 matches
Mail list logo