D9124: make packageurlinterceptor as noop as possible

2017-12-18 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:c318fde313fe: make packageurlinterceptor as noop as possible (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9124?vs=23906=24065#toc REPOSITORY R242 Plasma Framework

D9124: make packageurlinterceptor as noop as possible

2017-12-18 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D9124 REVISION DETAIL https://phabricator.kde.org/D9124 To: mart, #plasma, davidedmundson Cc: davidedmundson, ngraham, apol, plasma-devel,

D9124: make packageurlinterceptor as noop as possible

2017-12-14 Thread Marco Martin
mart updated this revision to Diff 23906. mart added a comment. - extra warning REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23905=23906 BRANCH arcpatch-D9124 REVISION DETAIL https://phabricator.kde.org/D9124 AFFECTED

D9124: make packageurlinterceptor as noop as possible

2017-12-14 Thread Marco Martin
mart updated this revision to Diff 23899. mart added a comment. - manage all cases for packages and check for file existence beforehand REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23490=23899 BRANCH arcpatch-D9124 REVISION

D9124: make packageurlinterceptor as noop as possible

2017-12-05 Thread Marco Martin
mart updated this revision to Diff 23490. mart added a comment. - use kpackage_install_bundled_package REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23463=23490 BRANCH phab/packegeFileUrl REVISION DETAIL

D9124: make packageurlinterceptor as noop as possible

2017-12-04 Thread David Edmundson
davidedmundson reopened this revision. davidedmundson added a comment. Was pushed in a branch, not master. Reopening on phab REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9124 To: mart, #plasma Cc: davidedmundson, ngraham, apol, plasma-devel,

D9124: make packageurlinterceptor as noop as possible

2017-12-04 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:d0cbef14cbdd: make packageurlinterceptor as noop as possible (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D9124: make packageurlinterceptor as noop as possible

2017-12-03 Thread Marco Martin
mart updated this revision to Diff 23397. mart added a comment. only toString once REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23328=23397 BRANCH phab/killurlinterceptor REVISION DETAIL https://phabricator.kde.org/D9124

D9124: make packageurlinterceptor as noop as possible

2017-12-03 Thread Aleix Pol Gonzalez
apol added a comment. Wow that's a lot of code gone! INLINE COMMENTS > packageurlinterceptor.cpp:95 > > -if (d->forcePlasmaStyle && > path.path().contains(QLatin1String("Controls.2/org.kde.desktop/"))) { > -return >

D9124: make packageurlinterceptor as noop as possible

2017-12-03 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY minimize file access during url rewrite we still need it for accessing stuff under