D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. external bug report: https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/26 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos abandoned this revision. mvourlakos added a comment. this is Adapta theme issue... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. In https://phabricator.kde.org/D9276#179574, @mart wrote: > here on master the item under mouse does get highlighted you are totally right!! so sorry... this is Adapta theme issue, changing to Breeze themes solves this... REPOSITORY R242 Plasma

D9276: highlight PlasmaComponents3.ComboBox list items

mart added a comment. here on master the item under mouse does get highlighted F5548404: Spectacle.Z15071.png INLINE COMMENTS > mvourlakos wrote in ComboBox.qml:49 > yes... it didnt highlight at all, neither the selected item nor the hovered > one...

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added inline comments. INLINE COMMENTS > mart wrote in ComboBox.qml:49 > uuh, no, ItemDelegate should highlight by itself when hovered without having > to do that, this would say that there is a problem in ItemDelegate? yes... it didnt highlight at all, neither the selected item nor

D9276: highlight PlasmaComponents3.ComboBox list items

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ComboBox.qml:49 > + > +background: Rectangle{ > +width: itemDelegate.width uuh, no, ItemDelegate should highlight by itself when hovered

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. just noticed that the reviewer is the person that decides to give the green light so it cant be set by the author without prior communication... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos removed a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY --PlasmaComponents.ComboBox now highlights correctly the selected item and on