D9338: [comic] Fix comic updater time interval

2017-12-22 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes. Closed by commit R114:095196ca6438: [comic] Fix update interval (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=24295=24303 REVISION DETAIL

D9338: [comic] Fix comic updater time interval

2017-12-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9338: [comic] Fix comic updater time interval

2017-12-22 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in comicupdater.cpp:86 > I assume this line is the important change? > > +1 to this bit. Yes. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson,

D9338: [comic] Fix comic updater time interval

2017-12-22 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 24295. anthonyfieroni marked 2 inline comments as done. anthonyfieroni edited the test plan for this revision. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=23936=24295 REVISION DETAIL

D9338: [comic] Fix comic updater time interval

2017-12-22 Thread David Edmundson
davidedmundson added a comment. Can you please fill in the "testing done" field on phabricator. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D9338: [comic] Fix comic updater time interval

2017-12-22 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > comicupdater.cpp:56 > +} else { > +mUpdateIntervall = 3; > } wouldn't you still need to call checkForUpdate() if you went into this path? Especially as checkForUpdate is the one that sets up the timer to call itself

D9338: [comic] Fix comic updater time interval

2017-12-21 Thread Anthony Fieroni
anthonyfieroni added a reviewer: mart. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9338: [comic] Fix comic updater time interval

2017-12-18 Thread Anthony Fieroni
anthonyfieroni added a comment. I plan to commit it this week, please review it, does something is not correct? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff,

D9338: [comic] Fix comic updater time interval

2017-12-16 Thread Anthony Fieroni
anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9338: [comic] Fix comic updater time interval

2017-12-14 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, broulik, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In case of invalid update interval every hour download manager stores