ngraham closed this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts, rkflx
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
rkflx accepted this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts, rkflx
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
ngraham marked 3 inline comments as done.
ngraham added a comment.
I'm agnostic about the `default` style, but I do see the utility of putting
it on top. I'll leave it that way unless anybody has strong objections.
Is this shippable now?
REPOSITORY
R31 Breeze
BRANCH
master
ngraham updated this revision to Diff 24854.
ngraham added a comment.
Handle inappropriately high numeric values set in pre-existing breezerc files
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9627?vs=24801=24854
BRANCH
master
REVISION DETAIL
rkflx added a comment.
Thanks for the review and your help ;)
INLINE COMMENTS
> hpereiradacosta wrote in breezedecoration.cpp:643
> Matter of taste.
> Some people (including me), like to have the default (fallback) choice first.
> Some others like to have it last.
> Some, inline.
> There
hpereiradacosta added a comment.
Other than that ... Ship it ! I'm fine with the change and happy to maintain
it in the future.
INLINE COMMENTS
> rkflx wrote in breezedecoration.cpp:643
> Ordering by size would be more readable, `default` doesn't have to sit at the
> top (it should just
rkflx added a comment.
In https://phabricator.kde.org/D9627#186696, @rkflx wrote:
> I won't need to test again, as the screenshots clearly show it working fine
;)
Never trust a screenshot…
INLINE COMMENTS
> breezedecoration.cpp:643
> +{
> +default:
>
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,
rkflx added a comment.
Thanks for the update. I won't need to test again, as the screenshots clearly
show it working fine ;)
If Hugo is happy with the code, this could land.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg,
ngraham edited the summary of this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
ngraham updated this revision to Diff 24801.
ngraham added a comment.
- Make Small replicate the old default shadow size
- Rename Normal to Medium
- Call the new default "Large"
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9627?vs=24771=24801
BRANCH
rkflx added a comment.
In https://phabricator.kde.org/D9627#186637, @ngraham wrote:
> In https://phabricator.kde.org/D9627#186631, @rkflx wrote:
>
> > Works for the menu, but the window shadow is not as before for me. Maybe
insert Tiny with 16px + 16px?
>
>
> Are you sure? the
ngraham added a comment.
In https://phabricator.kde.org/D9627#186631, @rkflx wrote:
> As we now have three comboboxes (sizes of shadow, border, window buttons)
all with slightly different options, we could think about unifying these, both
in the number of options (not too many) and the
rkflx added a comment.
In https://phabricator.kde.org/D9627#186592, @ngraham wrote:
> FWIW, I rather prefer abstract words instead of numbers, since then we have
more freedom to tweak the numbers under the hood in the future. The actual
numbers aren't important enough to show to the
abetts accepted this revision.
abetts added a comment.
Thanks guys!
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hpereiradacosta added a comment.
In https://phabricator.kde.org/D9627#186592, @ngraham wrote:
> FWIW, I rather prefer abstract words instead of numbers, since then we have
more freedom to tweak the numbers under the hood in the future. The actual
numbers aren't important enough to show
ngraham added a comment.
FWIW, I rather prefer abstract words instead of numbers, since then we have
more freedom to tweak the numbers under the hood in the future. The actual
numbers aren't important enough to show to the user IMHO. And if we do expose
the number, people will eventually
abetts added a comment.
In https://phabricator.kde.org/D9627#186584, @hpereiradacosta wrote:
> In https://phabricator.kde.org/D9627#186582, @abetts wrote:
>
> > Would you consider changing the word "Normal" for something more related
to measurements? For example, regular, default,
rkflx added a comment.
In https://phabricator.kde.org/D9627#186583, @ngraham wrote:
> How about "Medium"?
It's not really of size medium, isn't it? However, compared to before 3
different sizes are not that many anyway, so we could insert an extra / actual
"Medium", rename the
hpereiradacosta added a comment.
In https://phabricator.kde.org/D9627#186582, @abetts wrote:
> Would you consider changing the word "Normal" for something more related to
measurements? For example, regular, default, current. Normal works better in
other languages like Spanish where it
ngraham added a comment.
How about "Medium"?
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
abetts added a comment.
Would you consider changing the word "Normal" for something more related to
measurements? For example, regular, default, current. Normal works better in
other languages like Spanish where it is related to measurements. In English
that link is not as strong.
ngraham edited the summary of this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
ngraham edited the summary of this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
ngraham edited the summary of this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
ngraham retitled this revision from "Use combobox to choose shadow size and
reduce menu shadows to 25% of window shadow size" to "Use combobox to choose
shadow size and use more appropriate values for menu & tooltip shadow sizes".
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
29 matches
Mail list logo
