D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

2018-01-14 Thread Fabian Vogt
fvogt closed this revision. fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixed up the trailing whitespace in line 165 and landed: https://commits.kde.org/kwin/eb69e87288d37fdb13eca32ca807ed8279f912af REPOSITORY R108 KWin REVISION DETAIL

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

2018-01-14 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9873 To: fvogt, #plasma, graesslin Cc: kwin,

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

2018-01-14 Thread Fabian Vogt
fvogt updated this revision to Diff 25351. fvogt added a comment. Restricted Application edited projects, added KWin; removed Plasma. Move the added functions from the class into the xkb.cpp's static scope. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

2018-01-14 Thread Fabian Vogt
fvogt added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9873#190789, @graesslin wrote: > I wasn't aware of this secure_getenv functionality. Me neither... > Is that also in place after the process has

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

2018-01-14 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. I wasn't aware of this secure_getenv functionality. Is that also in place after the process has completely dropped all privs? INLINE COMMENTS > xkb.h:121-127 > +static bool

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

2018-01-14 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin. fvogt requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY