anemeth added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
This change will be superseded by: https://phabricator.kde.org/D9848
I just removed the caching blur altogether.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9879
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e200d7403110: [effects/blur] Disable texture cache on
Wayland (authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
CHANGES SINCE LAST
broulik accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
BRANCH
blur-no-cache-wayland
REVISION DETAIL
https://phabricator.kde.org/D9879
To: graesslin, #kwin, #plasma, broulik
luebking added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
On a general note, UI-wise: if there's no way to ever enable an item it
should not be shown anyway.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9879
To: graesslin, #kwin,
graesslin updated this revision to Diff 25345.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Hide option instead of disable it
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9879?vs=25343=25345
BRANCH
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9879#190916, @graesslin wrote:
> Also disable the cache blur checkbox on Wayland
ah no, that's a stupid idea. The load call enables it again. I'll hide
graesslin updated this revision to Diff 25343.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Also disable the cache blur checkbox on Wayland
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9879?vs=25342=25343
broulik added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> blur_config.cpp:42
> +if (KWindowSystem::isPlatformWayland()) {
> +ui.kcfg_CacheTexture->setEnabled(false);
> +}
Shouldn't it hide or at least disable the check
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.
