mart marked 3 inline comments as done.
mart added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> graesslin wrote in tabletmodemanager.cpp:87-96
> I meant the method setTabletModeAvailable, your reply seems to be for
> isTabletModeAvailable?
mart marked an inline comment as done.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9944
To: mart, #kwin, #plasma
Cc: graesslin, ngraham, davidedmundson, plasma-devel, kwin, iodelay, bwowk,
ZrenBot, pro
mart updated this revision to Diff 25865.
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Merge branch 'master' into phab/tabletModeSupported
- remove unneeded method
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> mart wrote in tabletmodemanager.cpp:87-96
> yes, the point is to expose it to applications (on plasma i wouldn't want a
> "show this only in tablet mode" option visible (or at l
mart added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> graesslin wrote in tabletmodemanager.cpp:87-96
> is this method still needed?
yes, the point is to expose it to applications (on plasma i wouldn't want a
"show this only in tablet m
graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> tabletmodemanager.cpp:87-96
> +void TabletModeManager::setTabletModeAvailable(bool available)
> +{
> +//TODO: we need to access to libinput::connection from here
> +if (m
mart marked an inline comment as done.
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9944
To: mart, #kwin, #plasma
Cc: graesslin, ngraham, davidedmundson, plasma-devel, kwin, iodelay, bwowk,
ZrenBot, pro
mart updated this revision to Diff 25794.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- fix logic
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9944?vs=25763&id=25794
BRANCH
phab/tabletModeSupported
REVISION D
graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> input.cpp:1897
> +#endif
> +return true;
> +}
false
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9944
To: mart, #kwin, #plasma
Cc: graesslin, ngr
mart updated this revision to Diff 25763.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- wire up tabletModeAvailable
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9944?vs=25537&id=25763
BRANCH
phab/tabletModeSup
mart added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> graesslin wrote in tabletmodemanager.cpp:87
> makes sense. VirtualKeyboard also accesses the information through input
ok, i'll try to add an api for that in thir rr then
REPOSITORY
graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> mart wrote in tabletmodemanager.cpp:87
> which, would make sense api-wise even if something different than libinput
> was used underneath
makes sense. VirtualKeyboard also acce
mart added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> mart wrote in tabletmodemanager.cpp:87
> I tought as much, but would be possible then to expose the property in an
> abstract way from the core for this to read?
> maybe something al
mart added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> graesslin wrote in tabletmodemanager.cpp:87
> Impossible! That's violating the layering. KWin core does not depend or
> interact with libinput for our overall sanity.
I tought as mu
graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS
> tabletmodemanager.cpp:87
> +{
> +//TODO: we need to access to libinput::connection from here
> +if (m_tabletModeAvailable == available) {
Impossible! That's violating th
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9944
To: mart, #kwin, #plasma
Cc: ngraham, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
api-wise on the dbus side, could also be done that the interface being there
means the switch is possible, otherwise doesn't get registered/destroyed
REPOSITORY
R108 KWin
REVISION DETAIL
https://pha
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9944#192397, @davidedmundson wrote:
> 2. trying to be a canonical source of what mode a device is in from all
information available (which currently happens to be the
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In terms of goals, is this interface:
1. about exposing the raw switch data that we have from libinput
2. trying to be a canonical source of what mode a device is in from all
informati
mart created this revision.
mart added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
mart requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.
REVISION SUMMARY
20 matches
Mail list logo
