D9965: Provide a tooltip for the main action

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3db732db861b: Provide a tooltip for the main action (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9965?vs=25655=25771#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST

D9965: Provide a tooltip for the main action

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D9965 To: apol, #kirigami, mart Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D9965: Provide a tooltip for the main action

apol updated this revision to Diff 25655. apol added a comment. No tooltip on mobile REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9965?vs=25653=25655 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9965 AFFECTED FILES

D9965: Provide a tooltip for the main action

apol updated this revision to Diff 25653. apol added a comment. Make it work for the other actions as well REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9965?vs=25601=25653 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9965 AFFECTED

D9965: Provide a tooltip for the main action

mart added inline comments. INLINE COMMENTS > apol wrote in ActionButton.qml:115 > We can create a new Kirigami.Units.toolTipDelay +1, and the desktop style could use the value provided by qwidgets (while for the other ones is fine a sensible-looking hardcoded value) REPOSITORY R169

D9965: Provide a tooltip for the main action

mart added a comment. in general, +1, tough there is something more to do here. it already shown a notification on press and hold with the text, which should be ported to qqc2 tooltips instead of both things on top of each other. also, should depend from Settings.isMobile: when false, it

D9965: Provide a tooltip for the main action

apol added inline comments. INLINE COMMENTS > broulik wrote in ActionButton.qml:115 > Unfortunately there's no non-widgets API to get it but Qt uses 700 ms as > `SH_ToolTip_WakeUpDelay` We can create a new Kirigami.Units.toolTipDelay REPOSITORY R169 Kirigami REVISION DETAIL

D9965: Provide a tooltip for the main action

broulik added inline comments. INLINE COMMENTS > ActionButton.qml:115 > +Controls.ToolTip.text: action ? action.text : "" > +Controls.ToolTip.delay: Units.longDuration > + Unfortunately there's no non-widgets API to get it but Qt uses 700 ms as `SH_ToolTip_WakeUpDelay`

D9965: Provide a tooltip for the main action

apol added a comment. With tooltip F5662283: Screenshot_20180118_172541.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9965 To: apol, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D9965: Provide a tooltip for the main action

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This way there's a chance to see the action text without clicking