Re: Kirigami: pageRow refactor ready for testing

2016-04-26 Thread Marco Martin
On Friday 22 April 2016, Dirk Hohndel wrote: > > tried on the laptop so far, after a few fixes on the branch it seems to > > work fine (not super familiar on all aspects of the app tough) > > the only thing, i would then push the little change on the header api > > that caused problems, for which

Re: Kirigami: pageRow refactor ready for testing

2016-04-22 Thread Dirk Hohndel
On Fri, Apr 22, 2016 at 06:37:38PM +0200, Marco Martin wrote: > On Thursday 21 April 2016 11:38:25 Dirk Hohndel wrote: > > > from my tests on the gallery app it seems at least not to have > > > regressions (hopefully should work a bit better) > > > if from tests looks like it works better, I'll

Re: Kirigami: pageRow refactor ready for testing

2016-04-22 Thread Marco Martin
On Thursday 21 April 2016 11:38:25 Dirk Hohndel wrote: > > from my tests on the gallery app it seems at least not to have > > regressions (hopefully should work a bit better) > > if from tests looks like it works better, I'll merge it shortly. > > Have you tried building Subsurface-mobile against

Re: Kirigami: pageRow refactor ready for testing

2016-04-21 Thread Marco Martin
On Thursday 21 April 2016 11:38:25 Dirk Hohndel wrote: > > from my tests on the gallery app it seems at least not to have > > regressions (hopefully should work a bit better) > > if from tests looks like it works better, I'll merge it shortly. > > Have you tried building Subsurface-mobile against

Re: Kirigami: pageRow refactor ready for testing

2016-04-21 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 08:33:19PM +0200, Marco Martin wrote: > Hi all, > i think my rewrite of PageRow is almost done > here's a review request on phab: https://phabricator.kde.org/D1460 > some test would be welcome, it should be pretty easy, just to switch > to the branch > mart/PageRow5.6 > in

Kirigami: pageRow refactor ready for testing

2016-04-21 Thread Marco Martin
Hi all, i think my rewrite of PageRow is almost done here's a review request on phab: https://phabricator.kde.org/D1460 some test would be welcome, it should be pretty easy, just to switch to the branch mart/PageRow5.6 in the kirigami repo from my tests on the gallery app it seems at least not to