Re: Making paths case insensitive in krunner

2009-01-24 Thread Diaa Sami
Any comments about the patch? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Making paths case insensitive in krunner

2009-01-19 Thread Diaa Sami
On Sat, 17 Jan 2009 10:50 -0700, Aaron J. Seigo ase...@kde.org wrote: sure; if you can come to the list with some patches, i see no reason (assuming the performance is still good =) they couldn't go in... You can find an initial version of the patch below, it looks like it works fast

Re: Making paths case insensitive in krunner

2009-01-19 Thread Diaa Sami
The previous patch had some mistakes, please use this one instead Index: kdelibs/plasma/runnercontext.cpp === --- kdelibs/plasma/runnercontext.cpp(revision 911086) +++ kdelibs/plasma/runnercontext.cpp(working copy) @@ -47,6

Re: Making paths case insensitive in krunner

2009-01-19 Thread Aaron J. Seigo
On Monday 19 January 2009, Diaa Sami wrote: On Sat, 17 Jan 2009 10:50 -0700, Aaron J. Seigo ase...@kde.org wrote: sure; if you can come to the list with some patches, i see no reason (assuming the performance is still good =) they couldn't go in... You can find an initial version of the

Re: Making paths case insensitive in krunner

2009-01-19 Thread Diaa Sami
On Mon, 19 Jan 2009 11:08 -0700, Aaron J. Seigo ase...@kde.org wrote: however, the code itself needs to be written following our coding style guidelines: http://techbase.kde.org/Policies/Kdelibs_Coding_Style qDebug should be kDebug; QString whatever = should be

Re: Making paths case insensitive in krunner

2009-01-17 Thread Aaron J. Seigo
On Friday 16 January 2009, Diaa Sami wrote: My name is Diaa sami and I'm relatively new to KDE development, recently welcome to KDE, Diaa =) I've been working on making path completion in KDE case insensitive[1], which should be more productive, I've already made Konqueror, Dolphin and the

Re: Making paths case insensitive in krunner

2009-01-17 Thread Ivan Čukić
so what do you think? Cool idea. A bit off topic - in the file open/save dialogue, the case-insensitive completion works only in the name field, and not in the breadcrumb/location bar, while it does work (as you stated) in Dolphin. Cheerio! -- A positive attitude may not solve all your

Re: Making paths case insensitive in krunner

2009-01-17 Thread Diaa Sami
On Sat, 17 Jan 2009 18:57 +0100, Ivan Čukić ivan.cu...@gmail.com wrote: so what do you think? Cool idea. Glad the idea is appealing. A bit off topic - in the file open/save dialogue, the case-insensitive completion works only in the name field, and not in the breadcrumb/location

Making paths case insensitive in krunner

2009-01-16 Thread Diaa Sami
Hi, My name is Diaa sami and I'm relatively new to KDE development, recently I've been working on making path completion in KDE case insensitive[1], which should be more productive, I've already made Konqueror, Dolphin and the file dialogs provide case-insensitive path completion, these