Re: New devicenotifier moved to kdereview

2009-10-07 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: > trunk/kdereview/plasma/applets/devicenotifier-refactor given how far it's all come and where it's at now, i'd like to see this in trunk asap. it's a great step forward from what is currently in trunk and while there is more yet to do (e.g. keyboard na

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Aaron J. Seigo
On October 6, 2009, Jacopo De Simoi wrote: > On Tuesday 06 October 2009 22:17:02 Aaron J. Seigo wrote: > > so much for simplicity :/ > > I'm confused; I can read in test-predicate-openinwindow.desktop: > > X-KDE-Solid-Predicate=[ [ StorageVolume.ignored == false AND [ > StorageVolume.usage == 'F

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Aaron J. Seigo
On October 6, 2009, Jacopo De Simoi wrote: > On Tuesday 06 October 2009 21:58:08 Aaron J. Seigo wrote: > > > i think anyway a better approach would be to add an action > > > file for them, and add a property in the DeviceItem to set if they are > > > (un)mountable > > > > it would prevent any sp

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Kevin Ottens
On Tuesday 6 October 2009 22:17:02 Aaron J. Seigo wrote: > On October 6, 2009, Giulio Camuffo wrote: > > in my opinion the applet should show all the devices, fixed or not, fstab > > or not. i tried with the solidengine, but it doesn't show the other > > devices too. i think anyway a better appro

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Jacopo De Simoi
On Tuesday 06 October 2009 22:17:02 Aaron J. Seigo wrote: > so much for simplicity :/ I'm confused; I can read in test-predicate-openinwindow.desktop: X-KDE-Solid-Predicate=[ [ StorageVolume.ignored == false AND [ StorageVolume.usage == 'FileSystem' OR StorageVolume.usage == 'Encrypted' ] ] OR

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Jacopo De Simoi
On Tuesday 06 October 2009 21:58:08 Aaron J. Seigo wrote: > > i think anyway a better approach would be to add an action > > file for them, and add a property in the DeviceItem to set if they are > > (un)mountable > > it would prevent any special-case code in the notifier widget, yes. If we ha

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Aaron J. Seigo
On October 6, 2009, Giulio Camuffo wrote: > in my opinion the applet should show all the devices, fixed or not, fstab > or not. i tried with the solidengine, but it doesn't show the other > devices too. i think anyway a better approach would be to add an action > file for them, and add a propert

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Aaron J. Seigo
On October 6, 2009, Giulio Camuffo wrote: > In data martedì 06 ottobre 2009 18:16:23, Aaron J. Seigo ha scritto: > : > On October 6, 2009, Giulio Camuffo wrote: > : > > > > or do you mean it doesn't show your / or /home? unfortunately the > > > dataengines don't manage volumes handles by fstab, bu

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Giulio Camuffo
In data martedì 06 ottobre 2009 18:16:23, Aaron J. Seigo ha scritto: : > On October 6, 2009, Giulio Camuffo wrote: > > or do you mean it doesn't show your / or /home? unfortunately the > > dataengines don't manage volumes handles by fstab, but only by hal > > it doesn't show either of my disk par

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Kevin Ottens
On Tuesday 6 October 2009 20:56:53 Aaron J. Seigo wrote: > On October 6, 2009, Kevin Ottens wrote: > > probably filter them out somehow. There's an "ignore" hint on those > > devices which it probably honors by default, it's probably just a matter > > of changing the behavior of the engine to repor

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Aaron J. Seigo
On October 6, 2009, Kevin Ottens wrote: > probably filter them out somehow. There's an "ignore" hint on those devices > which it probably honors by default, it's probably just a matter of > changing the behavior of the engine to report them all along with their > ignore hint and do the filtering

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Aaron J. Seigo
On October 6, 2009, Giulio Camuffo wrote: > or do you mean it doesn't show your / or /home? unfortunately the > dataengines don't manage volumes handles by fstab, but only by hal it doesn't show either of my disk partitions or the internal disk either. i don't expect fstab style handling, but i

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Kevin Ottens
On Tuesday 6 October 2009 21:49:36 Giulio Camuffo wrote: > or do you mean it doesn't show your / or /home? unfortunately the > dataengines don't manage volumes handles by fstab, but only by hal That'd be surprising. Those volumes are also reported by HAL (and then Solid), the data engine probab

Re: New devicenotifier moved to kdereview

2009-10-06 Thread Giulio Camuffo
In data lunedì 05 ottobre 2009 23:28:47, Aaron J. Seigo ha scritto: : > On October 4, 2009, Jacopo De Simoi wrote: > > now, we believe that it is ready for merging into trunk. Of course we > > need your feedback first, so grab it, try it out and tell us what you > > think! > > what items should b

Re: New devicenotifier moved to kdereview

2009-10-05 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: > now, we believe that it is ready for merging into trunk. Of course we need > your feedback first, so grab it, try it out and tell us what you think! what items should be showing up when i select "all items"? it doesn't show the hard disk inside the l

Re: New devicenotifier moved to kdereview

2009-10-05 Thread Aaron J. Seigo
On October 5, 2009, Aaron J. Seigo wrote: > On October 4, 2009, Giulio Camuffo wrote: > > In data domenica 04 ottobre 2009 20:31:49, Aaron J. Seigo ha scritto: > > : > On October 4, 2009, Jacopo De Simoi wrote: > > well, actually you can't open two devices at a time, so if we keep this > > behavi

Re: New devicenotifier moved to kdereview

2009-10-05 Thread Aaron J. Seigo
On October 4, 2009, Giulio Camuffo wrote: > In data domenica 04 ottobre 2009 20:31:49, Aaron J. Seigo ha scritto: > : > On October 4, 2009, Jacopo De Simoi wrote: > : > > > > On Sunday 04 October 2009 20:57:11 Aaron J. Seigo wrote: > > > > On October 4, 2009, Jacopo De Simoi wrote: > > consider t

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Sebastian Kügler
On Sunday 04 October 2009 18:52:34 Giulio Camuffo wrote: > 2009/10/4 Aaron J. Seigo > > On October 4, 2009, Jacopo De Simoi wrote: > > now, we believe that it is ready for merging into trunk. Of course we > > need > > > > your feedback first, so grab it, try it out and tell us what you think!

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
On Sunday 04 October 2009 22:31:49 Aaron J. Seigo wrote: > > > * when an item is expanded, should the background remain painted? it > > > might make it more evident that the item is "open", and it would also > > > allow a way to solve the next point, too. (and if the background remains, > > > perh

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Giulio Camuffo
In data domenica 04 ottobre 2009 20:31:49, Aaron J. Seigo ha scritto: : > On October 4, 2009, Jacopo De Simoi wrote: > > On Sunday 04 October 2009 20:57:11 Aaron J. Seigo wrote: > > > On October 4, 2009, Jacopo De Simoi wrote: > > > > now, we believe that it is ready for merging into trunk. Of cou

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: > On Sunday 04 October 2009 20:57:11 Aaron J. Seigo wrote: > > On October 4, 2009, Jacopo De Simoi wrote: > > > now, we believe that it is ready for merging into trunk. Of course we > > > need your feedback first, so grab it, try it out and tell us what y

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
> * when an item is expanded, should the background remain painted? it might > make it more evident that the item is "open", and it would also allow a way > to > solve the next point, too. (and if the background remains, perhaps the > capacity bar should too?) Now that I think some more about

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Giulio Camuffo wrote: > yes, but someone could find the popup coming without asking annoying, while > simply a click would be enough. i can imagine any number of things being annoying to someone out there. if that is the measure for when an option should be included, everyth

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
> just move it back to playground. Done. > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
On Sunday 04 October 2009 20:57:11 Aaron J. Seigo wrote: > On October 4, 2009, Jacopo De Simoi wrote: > > now, we believe that it is ready for merging into trunk. Of course we need > > your feedback first, so grab it, try it out and tell us what you think! > > with options out of the way :) some

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Giulio Camuffo
In data domenica 04 ottobre 2009 17:53:24, Aaron J. Seigo ha scritto: : > On October 4, 2009, Giulio Camuffo wrote: > > > the point of this thing is as a device *notifier*. it's not just a > > > device *lister*. > > > > but in the real world the main point of this applet is to access the > > device

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: > now, we believe that it is ready for merging into trunk. Of course we need > your feedback first, so grab it, try it out and tell us what you think! with options out of the way :) some thoughts on the plasmoid itself: * it still says "Devices recentl

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Giulio Camuffo wrote: > > the point of this thing is as a device *notifier*. it's not just a device > > *lister*. > > but in the real world the main point of this applet is to access the > devices, because if i insert a cd or a usb drive i don't need the computer > to tell me t

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Giulio Camuffo
2009/10/4 Aaron J. Seigo > On October 4, 2009, Jacopo De Simoi wrote: > > now, we believe that it is ready for merging into trunk. Of course we > need > > your feedback first, so grab it, try it out and tell us what you think! > > i still don't see the need for either of the popup control optio

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: > now, we believe that it is ready for merging into trunk. Of course we need > your feedback first, so grab it, try it out and tell us what you think! i still don't see the need for either of the popup control options. why should we care how long it po

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Aaron J. Seigo
On October 4, 2009, Jacopo De Simoi wrote: > On Sunday 04 October 2009 12:36:49 you wrote: > > > **Please notice that there is a OLD devicenotifier in kdereview; make > > > sure you grab the right one** > > > > This is a joke right? Can't the plasma team make their mind up and remove > > the old on

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
On Sunday 04 October 2009 12:36:49 you wrote: > > **Please notice that there is a OLD devicenotifier in kdereview; make sure > > you grab the right one** > > This is a joke right? Can't the plasma team make their mind up and remove the > old one if it's deprecated by this one? > I should at le

Re: New devicenotifier moved to kdereview

2009-10-04 Thread Albert Astals Cid
A Diumenge, 4 d'octubre de 2009, Jacopo De Simoi va escriure: > Dear plasma-devs, hardware-devs, core-devs, > > giucam and I, with some very-much-appreciated help by notmart have been > lately quite busy porting the devicenotifier to use QGraphicsWidgets; the > superficial look-and-feel is pre

New devicenotifier moved to kdereview

2009-10-04 Thread Jacopo De Simoi
Dear plasma-devs, hardware-devs, core-devs, giucam and I, with some very-much-appreciated help by notmart have been lately quite busy porting the devicenotifier to use QGraphicsWidgets; the superficial look-and-feel is pretty much the same as the old device notifier, plus the notable improvem