Re: Planning merging the single qqml engine

2015-05-21 Thread David Edmundson
On Mon, May 18, 2015 at 9:18 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Mon, May 18, 2015 at 8:28 PM, Marco Martin notm...@gmail.com wrote: Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Monday 18 May 2015, Ivan Čukić wrote: While I'm usually more conservative, I do think that something more decisive should be done in this case (and cases like these). While we do not want to break everything with each new release (wink wink ghm ghm nudge nudge), I don't think we want to

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Tuesday 19 May 2015, Marco Martin wrote: On Monday 18 May 2015, Ivan Čukić wrote: While I'm usually more conservative, I do think that something more decisive should be done in this case (and cases like these). While we do not want to break everything with each new release (wink wink ghm

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Monday 18 May 2015, David Edmundson wrote: Now to make you hate me. I have a crash, https://paste.kde.org/ppeqjl1c1 That's running: kdeclarative - your branch plasma-framework - your branch plsama-workspace - master (which is pretty close to running latest frameworks with Plasma 5.3)

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Monday 18 May 2015, Ivan Čukić wrote: - make it opt-in (as Marco says) - deprecate it - report notifications to the user 'this applet might make your desktop unstable' for all used applets that haven't opted-in - this would serve as a notification both to the users and the developers of

Re: Planning merging the single qqml engine

2015-05-19 Thread David Edmundson
On Mon, May 18, 2015 at 8:28 PM, Marco Martin notm...@gmail.com wrote: Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? In the end i managed to get a

Re: Planning merging the single qqml engine

2015-05-19 Thread Marco Martin
On Tuesday 19 May 2015, David Edmundson wrote: I would like to have all set before frameworks 5.11 One thing you and I talked about once was having the shell have a hook in p-f to call a static method setting what version of plasma-framework it was expecting. Would that be a suitable

Planning merging the single qqml engine

2015-05-18 Thread Marco Martin
Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? In the end i managed to get a single engine for the whole session, views included (had to duplicate the

Re: Planning merging the single qqml engine

2015-05-18 Thread Mark Gaiser
On Mon, May 18, 2015 at 9:28 PM, Marco Martin notm...@gmail.com wrote: Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? In the end i managed to get a

Re: Planning merging the single qqml engine

2015-05-18 Thread Marco Martin
On Monday 18 May 2015, Mark Gaiser wrote: Anyway, with that attribute you let the applet developer OPT-IN in for shared engine. Setting that attribute can be easily forgotten. If anything, they should OPT-OUT thus by default use the shared engine. Perhaps a attribute like this is more

Re: Planning merging the single qqml engine

2015-05-18 Thread Kai Uwe Broulik
Hi, That's running: kdeclarative - your branch plasma-framework - your branch plsama-workspace - master (which is pretty close to running latest frameworks with Plasma 5.3) Are there any significant changes in plasma-workspace and plasma-desktop, other than applet migration, since there's

Re: Planning merging the single qqml engine

2015-05-18 Thread Marco Martin
On Monday 18 May 2015, Kai Uwe Broulik wrote: What I found interesting that you changed import plasmapkg:/code/logic.js to import logic.js although the qml file is in a different folder, why does that work? since it can still figure out the package, the url interceptor takes js files from

Re: Planning merging the single qqml engine

2015-05-18 Thread Ivan Čukić
While I'm usually more conservative, I do think that something more decisive should be done in this case (and cases like these). While we do not want to break everything with each new release (wink wink ghm ghm nudge nudge), I don't think we want to support every

Re: Planning merging the single qqml engine

2015-05-18 Thread Ivan Čukić
The ironic thing here is that something would have to be introduced that will be deprecated Not really. It would deprecate the old qml engine per plasmoid. It is not about deprecating the opt-in thing. The ideal is to achieve 100% opt-in, that is, for all plugins to eventually get the

Re: Planning merging the single qqml engine

2015-05-18 Thread Mark Gaiser
On Mon, May 18, 2015 at 9:53 PM, Marco Martin notm...@gmail.com wrote: On Monday 18 May 2015, Mark Gaiser wrote: Anyway, with that attribute you let the applet developer OPT-IN in for shared engine. Setting that attribute can be easily forgotten. If anything, they should OPT-OUT thus by

Re: Planning merging the single qqml engine

2015-05-18 Thread David Edmundson
On Mon, May 18, 2015 at 8:28 PM, Marco Martin notm...@gmail.com wrote: Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? Thanks for doing all that.