Re: Re: Fwd: back developing [KRunner Bookmarks for chrome]

2012-07-20 Thread Marco Gulino
Ok, pushed branch is plasma/bookmarksrunner-chrome-gulino (based on 4.9, will forward port to master after the review). Basically i extracted major responsibilities into separate classes, created an interface Browser, and added Chrome/Chromium support via QJson (should it be an optional dependency

Re: Re: Fwd: back developing [KRunner Bookmarks for chrome]

2012-07-20 Thread Marco Gulino
Thank you, but this proxy is kinda too much restrictive, i can use https, but ssh on https port doesn't seem to work. Anyway, not a big deal... in a few hours i'll be on holiday for a whole month, no proxy or firewalls in the way :) On Fri, Jul 20, 2012 at 1:11 PM, Ben Cooksley wrote: > > In case

Re: Re: Fwd: back developing [KRunner Bookmarks for chrome]

2012-07-20 Thread Ben Cooksley
On Fri, Jul 20, 2012 at 8:07 PM, Marco Gulino wrote: > > On Fri, Jul 20, 2012 at 11:50 AM, Alex Fiestas wrote: >> >> >> > If it's ok I can start pushing refactored code to master starting >> > tomorrow. >> That was fast! :p > > > I was in Tibet the last 4 years, i learned some secret refactoring

Re: Re: Fwd: back developing [KRunner Bookmarks for chrome]

2012-07-20 Thread Marco Gulino
On Fri, Jul 20, 2012 at 11:50 AM, Alex Fiestas wrote: > > > If it's ok I can start pushing refactored code to master starting > tomorrow. > That was fast! :p > I was in Tibet the last 4 years, i learned some secret refactoring tecniques :P Also, these two days i don't have much stuff to do at wo

Re: Re: Fwd: back developing [KRunner Bookmarks for chrome]

2012-07-20 Thread Alex Fiestas
On Friday 20 July 2012 01:31:23 you wrote: > Well yes, but i don't mean to develop a separate runner, just add chrome > support to the existing one (which already supports Firefox and Opera too). > And yes, i saw a chrome runner too, but it's a standalone runner. I'll > probably still look at it, b

Re: Fwd: back developing [KRunner Bookmarks for chrome]

2012-07-19 Thread Marco Gulino
Well yes, but i don't mean to develop a separate runner, just add chrome support to the existing one (which already supports Firefox and Opera too). And yes, i saw a chrome runner too, but it's a standalone runner. I'll probably still look at it, but the main point is to refactor the existing one f

Re: Fwd: back developing [KRunner Bookmarks for chrome]

2012-07-19 Thread Alex Fiestas
You don't need a branch to develop a runner, you can actually do it in a separate repo, maybe a kde scratch ? Something tells me that I have seen a chrome bookmark runner before... but maybe I'm wrong (for sure I have seen the firefox one). Cheerz ! _