Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2015-04-04 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/ --- (Updated April 4, 2015, 4:15 p.m.) Status -- This change has been

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/#review56949 --- The idea makes sense, however it's on Plasma1, that shouldn't

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-30 Thread Gregor Mi
On April 30, 2014, 9:04 a.m., Marco Martin wrote: The idea makes sense, however it's on Plasma1, that shouldn't have nev changes in. best thing would be to have this done directly in plasam2 Thanks for the affirmation. So I keep this request open until the the plasma2 version of the

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-29 Thread Gregor Mi
On April 27, 2014, 8:10 p.m., Aleix Pol Gonzalez wrote: .reviewboardrc, line 1 https://git.reviewboard.kde.org/r/117802/diff/1/?file=268625#file268625line1 That should go in a separate commit, but feel free to submit it. commited with bc00d6e34ce738febe2487be012e5131e8f858a4 on

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-29 Thread Gregor Mi
On April 27, 2014, 8:10 p.m., Aleix Pol Gonzalez wrote: .gitignore, line 1 https://git.reviewboard.kde.org/r/117802/diff/1/?file=268624#file268624line1 You probably don't want to submit this file, you can have gitignore set system-wide, if you want. You are right. Thanks for the

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-29 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/ --- (Updated April 30, 2014, 1:26 a.m.) Review request for Plasma, Aleix Pol

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-27 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/ --- (Updated April 27, 2014, 5:55 p.m.) Review request for Plasma, Aleix Pol

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2014-04-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/#review56691 --- .gitignore