Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/ --- (Updated Feb. 19, 2016, 12:27 p.m.) Status -- This change has been

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Feb. 19, 2016, 12:02 p.m., David Edmundson wrote: > > src/plasmaquick/appletquickitem.cpp, lines 572-573 > > > > > > can you get rid of this. > > > > I think it's trying to do what your patch

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92552 --- Fix it, then Ship it!

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Feb. 15, 2016, 4:29 p.m., David Edmundson wrote: > > src/plasmaquick/appletquickitem.cpp, line 736 > > > > > > if that's the case, filter on event->child()->metaObject.className() > > > > rather

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92406 --- src/plasmaquick/appletquickitem.cpp (line 736)

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Фев. 15, 2016, 12:06 след обяд, Marco Martin wrote: > > src/plasmaquick/appletquickitem.cpp, line 55 > > > > > > why splitting it in a separate method if you don't call it from > > anywhere else? > > David

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92387 --- Fix it, then Ship it! fine with an issue

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Feb. 13, 2016, 11:33 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/appletquickitem.h, line 149 > > > > > > This looks binary incompatible. > > > > Also, add Q_DECL_OVERRIDE > > David Rosca

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92328 --- src/plasmaquick/appletquickitem.h (line 149)

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

> On Feb. 13, 2016, 11:33 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/appletquickitem.h, line 149 > > > > > > This looks binary incompatible. > > > > Also, add Q_DECL_OVERRIDE Looks fine to me

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/ --- (Updated Feb. 13, 2016, 11:48 p.m.) Review request for Plasma. Changes