Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-15 Thread David Edmundson
> On March 15, 2016, 3:15 p.m., David Rosca wrote: > > Are you sure this fixes it? I've tested it now with Qt 5.5 and it just > > completely broke the skip taskbar feature (= plasma popups are shown ALWAYS > > in taskbar). I was experimenting with various workarounds too, but found > > none

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-15 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/#review93558 --- Are you sure this fixes it? I've tested it now with Qt 5.5

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/ --- (Updated March 15, 2016, 3:36 p.m.) Status -- This change has been

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-15 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/#review93531 --- Ship it! I'd say flesh out the comment a bit more to

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-14 Thread David Edmundson
> On March 14, 2016, 7:10 p.m., Kai Uwe Broulik wrote: > > Doesn't https://codereview.qt-project.org/#/c/149013/ fix that? > > David Edmundson wrote: > Oh wow thanks. I'd just started redoing the same patch. I could have > wasted quite some time. > > David Rosca is super awesome.

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-14 Thread Kai Uwe Broulik
> On März 14, 2016, 7:10 nachm., Kai Uwe Broulik wrote: > > Doesn't https://codereview.qt-project.org/#/c/149013/ fix that? > > David Edmundson wrote: > Oh wow thanks. I'd just started redoing the same patch. I could have > wasted quite some time. > > David Rosca is super awesome.

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-14 Thread Kai Uwe Broulik
> On März 14, 2016, 7:10 nachm., Kai Uwe Broulik wrote: > > Doesn't https://codereview.qt-project.org/#/c/149013/ fix that? > > David Edmundson wrote: > Oh wow thanks. I'd just started redoing the same patch. I could have > wasted quite some time. > > David Rosca is super awesome.

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-14 Thread Anthony Fieroni
> On Март 14, 2016, 9:10 след обяд, Kai Uwe Broulik wrote: > > Doesn't https://codereview.qt-project.org/#/c/149013/ fix that? > > David Edmundson wrote: > Oh wow thanks. I'd just started redoing the same patch. I could have > wasted quite some time. > > David Rosca is super

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-14 Thread David Edmundson
> On March 14, 2016, 7:10 p.m., Kai Uwe Broulik wrote: > > Doesn't https://codereview.qt-project.org/#/c/149013/ fix that? Oh wow thanks. I'd just started redoing the same patch. I could have wasted quite some time. David Rosca is super awesome. However, this is still a better way of

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/#review93512 --- Doesn't https://codereview.qt-project.org/#/c/149013/ fix