Re: Reviews

2014-07-29 Thread Vishesh Handa
On Tue, Jul 29, 2014 at 12:07 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant. If

Re: Reviews

2014-07-29 Thread Marco Martin
On Tuesday 29 July 2014, David Edmundson wrote: Sorry for flooding the mailing list. I've spent the morning cleaning out some of Plasma's review requests. One was nearly 4 years old. good stuff. on the list of reviews you posted, i commented on them, separing those that i think could be

Re: Reviews

2014-07-29 Thread Bhushan Shah
Hello, On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre reviews open (about half are PMC), I'm not sure what the state of those is, are they awaiting reviews from the non-media centre devs, or just no longer relevant.

Re: Reviews

2014-07-29 Thread Shantanu Tushar Jha
This one needs to be discarded as well, https://git.reviewboard.kde.org/r/115865/ On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote: Hello, On Tue, Jul 29, 2014 at 3:37 PM, David Edmundson da...@davidedmundson.co.uk wrote: There are a /lot/ of Plasma Media Centre

Re: Reviews

2014-07-29 Thread Bhushan Shah
On Tue, Jul 29, 2014 at 5:15 PM, Bhushan Shah bhus...@gmail.com wrote: Following PMC reviews needs to be discarded, Some more, https://git.reviewboard.kde.org/r/114055/ - code is already in repo Non PMC, https://git.reviewboard.kde.org/r/117681/ - no review so far

Re: Reviews

2014-07-29 Thread Bhushan Shah
Some more, https://git.reviewboard.kde.org/r/118540/ - Already in codebase https://git.reviewboard.kde.org/r/105319/ - No activity so far https://git.reviewboard.kde.org/r/105932/ - No activity and can't be applied on top of plasma 5 https://git.reviewboard.kde.org/r/106123/ - No activity and 4.8