Re: Require passing unit tests

2022-06-15 Thread David Edmundson
Scripted and pushed. Lets take discussion about individual repos to the relevant MRs.

Re: Require passing unit tests

2022-04-12 Thread David Edmundson
>let's go for it at least p-w and plasma-integration and slowly aim for >everywhere plasma-integration is an example where the tests have failed since November **2020**! without anyone following up. Fixed that one now: https://invent.kde.org/plasma/plasma-integration/-/merge_requests/43 Though o

Re: Require passing unit tests

2022-04-11 Thread Marco Martin
let's go for it at least p-w andplasma-integration and slowly aim for everywhere On Mon, Apr 11, 2022 at 11:10 AM David Edmundson wrote: > > There's a new flag we can set on CI to fail a job if unit tests fail. > https://www.volkerkrause.eu/2022/04/09/kde-ci-required-unit-tests.html > > Catching

Re: Require passing unit tests

2022-04-11 Thread Nate Graham
On 4/11/22 05:01, Aleix Pol wrote: It could make sense to start with the one projects where we don't have flaky tests. Either way, I think our mid-term plan should be to apply this everywhere. This is pretty much my viewpoint too. Nate

Re: Require passing unit tests

2022-04-11 Thread Aleix Pol
On Mon, Apr 11, 2022 at 11:10 AM David Edmundson wrote: > > There's a new flag we can set on CI to fail a job if unit tests fail. > https://www.volkerkrause.eu/2022/04/09/kde-ci-required-unit-tests.html > > Catching things as early as possible will unquestionably be a good thing. > > Realistically

Require passing unit tests

2022-04-11 Thread David Edmundson
There's a new flag we can set on CI to fail a job if unit tests fail. https://www.volkerkrause.eu/2022/04/09/kde-ci-required-unit-tests.html Catching things as early as possible will unquestionably be a good thing. Realistically right now this is going to cause some merge failures as we know some