Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/ --- (Updated Jan. 8, 2013, 9:50 a.m.) Review request for Plasma and Aaron J. S

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 4:49 p.m., Xuetian Weng wrote: > > And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog > > use hardcoded dialogs/background svg path internally, which should be > > tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog > > paintEven

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 3 p.m., Xuetian Weng wrote: > > applets/icontasks/tooltips/tooltip.cpp, line 267 > > > > > > You'd better manually set > > > > setAttribute(Qt::WA_X11NetWmWindowTypeToolTip, true); > >

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 4:49 p.m., Xuetian Weng wrote: > > And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog > > use hardcoded dialogs/background svg path internally, which should be > > tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog > > paintEven

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-08 Thread Cedric Bellegarde
> On Jan. 7, 2013, 3 p.m., Xuetian Weng wrote: > > applets/icontasks/tooltips/tooltip.cpp, line 267 > > > > > > You'd better manually set > > > > setAttribute(Qt::WA_X11NetWmWindowTypeToolTip, true); > >

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Aaron J. Seigo
> On Jan. 7, 2013, 4:49 p.m., Xuetian Weng wrote: > > And I don't really think Plasma::Dialog is suitable here. Plasma::Dialog > > use hardcoded dialogs/background svg path internally, which should be > > tooltips. And paintEvent is duplicated, you don't really use Plasma::Dialog > > paintEven

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/#review24926 --- And I don't really think Plasma::Dialog is suitable here. Plasm

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/#review24918 --- applets/icontasks/tooltips/tooltip.cpp

Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Cedric Bellegarde
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/ --- Review request for Plasma and Aaron J. Seigo. Description --- Similia