Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-24 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-24 12:59:38.449340) Review request for Plasma, Aaron Seigo and

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-24 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3253 --- Ship it! - Aaron On 2009-11-24 12:59:38, Jacopo De Simoi wrote:

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-21 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-21 18:49:12.791648) Review request for Plasma, Aaron Seigo and

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-17 Thread Jacopo De Simoi
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-17 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- (Updated 2009-11-17 17:52:14.417634) Review request for Plasma, Aaron Seigo and

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-16 Thread Jacopo De Simoi
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnermanager.h, line 149 http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-16 Thread Aaron Seigo
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnermanager.h, line 149 http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3063 --- trunk/KDE/kdelibs/plasma/abstractrunner.h

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Aaron Seigo
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnermanager.h, line 149 http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if

Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-07 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/ --- Review request for Plasma, Aaron Seigo and Ryan Bitanga. Summary --- This