Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-08-30 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-08-30 16:39:32.923467) Review request for Plasma, Aaron Seigo and

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-08-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review2193 --- Ship it! i'm fine with this going in; line edit and text edits too,

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-08-30 Thread Michal Dutkiewicz
On 2009-08-30 19:40:51, Aaron Seigo wrote: i'm fine with this going in; line edit and text edits too, i think. but spinbox? i don't think it's that common to subclass it ...? OK, so maybe I'll add these widgets and then upload one bigger patch, tomorrow I'll have someone to test code. In

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-23 Thread Michal Dutkiewicz
On 2009-07-23 04:12:32, Aaron Seigo wrote: if this is needed (which it may be in this case) then it should not be done using a constructor imo but rather a setNativeWidget method. that a combobox is created and then discarded in the process is a non-issue (it's not a hot path and the

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-23 Thread Marco Martin
On Thursday 23 July 2009, Michal Dutkiewicz wrote: On 2009-07-23 04:12:32, Aaron Seigo wrote: if this is needed (which it may be in this case) then it should not be done using a constructor imo but rather a setNativeWidget method. that a combobox is created and then discarded in the

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-22 Thread Sebastian Kügler
On Tuesday 21 July 2009 17:55:33 Michal Dutkiewicz wrote: It's intended for 4.3 (better later than never..., didn't know that there is still no possibility to do something like this and no possibility to create custom Plasma themed widget). Note that it won't be accepted in 4.3, it's a feature

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-22 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review1722 --- if this is needed (which it may be in this case) then it should not

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review1705 --- I like the idea,since doesn't make sense a new plasma widget for

Re: Review Request: Custom combo boxes for Plasma::ComboBox

2009-07-21 Thread Michal Dutkiewicz
On 2009-07-21 18:37:25, Marco Martin wrote: I like the idea,since doesn't make sense a new plasma widget for every conceivale thing, i think adding the possibility (just for c++ ones?) of putting a subclass in does make the thing more flexible while not putting too many exported