Re: Review Request: Fix Add to desktop from Kickoff when you have several virtual desktops and you enable Different widgets for each desktop

2012-01-11 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/#review9744 --- Ship it! tiny ws issue, but otherwise ok. and why containment

Re: Review Request: Fix Add to desktop from Kickoff when you have several virtual desktops and you enable Different widgets for each desktop

2012-01-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/#review9749 --- This review has been submitted with commit

Re: Review Request: Fix Add to desktop from Kickoff when you have several virtual desktops and you enable Different widgets for each desktop

2012-01-11 Thread Martin Gräßlin
On Jan. 11, 2012, 1:29 p.m., Aaron J. Seigo wrote: tiny ws issue, but otherwise ok. and why containment starts from 0 - because that's where counting starts. that virtual desktops in KWindowSystem start at '1' is pretty silly, really. otherwise we end up with everything else being

Review Request: Fix Add to desktop from Kickoff when you have several virtual desktops and you enable Different widgets for each desktop

2012-01-06 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/ --- Review request for Plasma and Aaron J. Seigo. Description --- From

Re: Review Request: Fix Add to desktop from Kickoff when you have several virtual desktops and you enable Different widgets for each desktop

2012-01-06 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/ --- (Updated Jan. 6, 2012, 9:11 p.m.) Review request for Plasma and Aaron J.

Re: Review Request: Fix Add to desktop from Kickoff when you have several virtual desktops and you enable Different widgets for each desktop

2012-01-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/#review9628 --- I just consulted the documentation and checked the properties

Re: Review Request: Fix Add to desktop from Kickoff when you have several virtual desktops and you enable Different widgets for each desktop

2012-01-06 Thread Martin Gräßlin
On Jan. 6, 2012, 9:33 p.m., Martin Gräßlin wrote: I just consulted the documentation and checked the properties on my system: that looks like KWindowSystem is wrong. The first desktop is 0. And further studies show that the bug might be in KWin. Will investigate further... so just