---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21614
---
style is quite ok to me now.
functions could still be changed
On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote:
style is quite ok to me now.
functions could still be changed to
function foo()
{
...
}
actually, the style was finally updated to:
function foo() {
}
so no need to adjust this :)
- Aaron J.
On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote:
style is quite ok to me now.
functions could still be changed to
function foo()
{
...
}
Aaron J. Seigo wrote:
actually, the style was finally updated to:
function foo() {
}
so no need to adjust
On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote:
style is quite ok to me now.
functions could still be changed to
function foo()
{
...
}
Aaron J. Seigo wrote:
actually, the style was finally updated to:
function foo() {
}
so no need to adjust
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21622
---
Ship it!
Ship It!
- Marco Martin
On Nov. 6, 2012, 11:36
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21657
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21493
---
You should move the javascript functions to a separated
On Nov. 6, 2012, 5:53 p.m., Daker Pinheiro wrote:
You should move the javascript functions to a separated Javascript file.
It would keep the plasmoid modularized.
A repeater could be used for creating the digits button.
You should move the javascript functions to a separated Javascript
On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote:
applets/calculator/package/contents/ui/calculator.qml, lines 235-240
http://git.reviewboard.kde.org/r/107001/diff/4/?file=93822#file93822line235
Again my personal preference, but it cleans up your code. So here it is.
I
On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote:
applets/calculator/package/contents/ui/calculator.qml, lines 235-240
http://git.reviewboard.kde.org/r/107001/diff/4/?file=93822#file93822line235
Again my personal preference, but it cleans up your code. So here it is.
I
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
---
(Updated Nov. 6, 2012, 11:36 p.m.)
Review request for Plasma.
Changes
On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote:
applets/calculator/package/contents/ui/calculator.qml, line 231
http://git.reviewboard.kde.org/r/107001/diff/4/?file=93822#file93822line231
I guess all the string values need to be wrapped in i18nc(C) ..
Someone else would need to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21516
---
Actually, i think you can get rid of all the onClicked:
On Nov. 7, 2012, 12:02 a.m., Mark Gaiser wrote:
Actually, i think you can get rid of all the onClicked: someAction in all
the buttons since you are already catching those events in
Keys.onSomeAction.
... nevermind this one as well.
Those onClicked are for when a user presses the button
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
---
(Updated Nov. 6, 2012, 2:42 a.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
---
(Updated Nov. 6, 2012, 2:54 a.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/#review21342
---
this needs to be modified to match
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
---
(Updated Nov. 1, 2012, 11:36 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107001/
---
Review request for Plasma.
Description
---
This diff replaces the
19 matches
Mail list logo
