Re: Review Request: Qalculate: fix restoring of settings

2011-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5426 --- This review has been submitted with commit a14e51c48da6c8d92de8

Re: Review Request: Qalculate: fix restoring of settings

2011-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5425 --- This review has been submitted with commit 4e973ff3ef7ee549accf

Re: Review Request: Qalculate: fix restoring of settings

2011-08-05 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5424 --- Ship it! great! :) thanks for the patch; please commit at your

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Jef Steelant
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/ --- (Updated Aug. 4, 2011, 1:28 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Aaron J. Seigo
> On Aug. 4, 2011, 11:28 a.m., Jef Steelant wrote: > > applets/qalculate/qalculate_applet.cpp, line 250 > > > > > > I also removed this call to the parent PopopApplet::configChanged() > > since I did not see it in

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Jef Steelant
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5386 --- applets/qalculate/qalculate_applet.cpp

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5385 --- applets/qalculate/qalculate_applet.cpp

Re: Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/#review5384 --- adding the readSettings call in configChanged looks correct; how

Review Request: Qalculate: fix restoring of settings

2011-08-04 Thread Jef Steelant
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102208/ --- Review request for Plasma. Summary --- If settings were changed in th