Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-30 Thread Michal Dutkiewicz
> On 2009-08-30 16:51:34, Artur de Souza (MoRpHeUz) wrote: > > Do you have an svn account to ship it ? Otherwise just poke me on IRC. I have one, I'll commit it now. :-) - Michal --- This is an automatically generated e-mail. To reply,

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-30 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review2189 --- Ship it! Do you have an svn account to ship it ? Otherwise just poke

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-30 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 12:13:25.327179) Review request for Plasma. Changes --

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-30 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 11:53:32.697101) Review request for Plasma. Changes --

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Chani
On August 10, 2009 08:28:47 Chani wrote: > On August 10, 2009 00:13:41 Patrick Aljord wrote: > > This is kind of unrelated but wouldn't it be a good thing to turn the > > upload backends into a plasma data engine? I can see other plasmoids > > making use of uploading pics and even kde apps like ksn

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur Souza (MoRpHeUz)
On Monday 10 August 2009, 14:00 Michal Dutkiewicz wrote: > By the way, I could try to rewrite this applet from scratch and add for > example support for error messages (SIH returns different error messages > for example), that could be passed as signal parameter. Actually rewriting it to support

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
> On 2009-08-10 16:51:06, Artur de Souza (MoRpHeUz) wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, > > line 57 > > > > > > Minor but important: not sure if kdeplasma-addons have c

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:56:55.220998) Review request for Plasma. Changes --

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1964 --- /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimageho

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:41:16.451067) Review request for Plasma. Changes --

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
> On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, > > line 54 > > > > > > maybe you get the error post icon even after a successfu

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Chani
On August 10, 2009 00:13:41 Patrick Aljord wrote: > This is kind of unrelated but wouldn't it be a good thing to turn the > upload backends into a plasma data engine? I can see other plasmoids > making use of uploading pics and even kde apps like ksnapshot but I > have no idea whether kde apps can

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1950 --- /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimageho

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Artur Souza (MoRpHeUz)
On Monday 10 August 2009, 03:41 Chani wrote: > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting. > cpp > > 42 + 13? If I'm not wrong, this was taken from flickr upload plugin on kipi_plugins. -

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Patrick Aljord
This is kind of unrelated but wouldn't it be a good thing to turn the upload backends into a plasma data engine? I can see other plasmoids making use of uploading pics and even kde apps like ksnapshot but I have no idea whether kde apps can make use of plasma engines. -Pat

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-10 Thread Michal Dutkiewicz
> On 2009-08-10 06:41:57, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, > > line 43 > > > > > > 42 + 13? This is taken from Imageshack backend, strange notation indeed. ;-

Re: Review Request: Simplest Image Hosting support for pastebin applet

2009-08-09 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1948 --- hmm, I can't really comment on the nontrivial parts of the code... I d

Review Request: Simplest Image Hosting support for pastebin applet

2009-08-09 Thread Michal Dutkiewicz
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- Review request for Plasma. Summary --- This patch adds support for Simplest