Re: Review Request: Simplify pixmap handling for XEmbed-based systray

2011-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102770/#review7113 --- This review has been submitted with commit ae04d14bd49772257871

Re: Review Request: Simplify pixmap handling for XEmbed-based systray

2011-10-05 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102770/#review7109 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 4, 2011, 3:31 p.m

Re: Review Request: Simplify pixmap handling for XEmbed-based systray

2011-10-05 Thread Aaron J. Seigo
> On Oct. 5, 2011, 1:58 a.m., Aaron J. Seigo wrote: > > thanks for the patch ... :) > > > > the coding style should follow the kdelibs style, but that's a minor thing. > > mostly just the one question regarding something noted in a code comment: > > Luboš Luňák wrote: > I can run the file

Re: Review Request: Simplify pixmap handling for XEmbed-based systray

2011-10-05 Thread Luboš Luňák
> On Oct. 5, 2011, 1:58 a.m., Aaron J. Seigo wrote: > > thanks for the patch ... :) > > > > the coding style should follow the kdelibs style, but that's a minor thing. > > mostly just the one question regarding something noted in a code comment: I can run the file through the astyle command be

Re: Review Request: Simplify pixmap handling for XEmbed-based systray

2011-10-04 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102770/#review7095 --- thanks for the patch ... :) the coding style should follow the

Review Request: Simplify pixmap handling for XEmbed-based systray

2011-10-04 Thread Luboš Luňák
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102770/ --- Review request for Plasma. Description --- This patches changes syste