Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/#review2562 --- Ship it! I'm finally convinced, we need to fix some issues here and

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Aaron Seigo
On 2009-10-06 10:16:00, Jacopo De Simoi wrote: /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.cpp, line 390 http://reviewboard.kde.org/r/1790/diff/3/?file=12370#file12370line390 Now that the left(hehe)action stays activated when !isCollapsed() we should

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-06 Thread Giulio Camuffo
On 2009-10-06 10:16:00, Jacopo De Simoi wrote: /trunk/kdereview/plasma/applets/devicenotifier-refactor/deviceitem.cpp, line 152 http://reviewboard.kde.org/r/1790/diff/3/?file=12370#file12370line152 Here we should make sure to hide() the description Label; wrote: playing

Re: Review Request: Unified ItemBackground in new Device Notifier

2009-10-05 Thread Chani
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1790/#review2559 --- Ship it! I'm a little fuzzy on what's going on with the two items