Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-10-06 Thread Anselmo L. S. Melo
> On 2010-10-01 17:21:28, Aaron Seigo wrote: > > update to current trunk if needed, and let's get this in as well. > > Anselmo L. S. Melo wrote: > @agateau: I've updated this patch to current trunk [1] - I updated it > when I wrote another patch [2], to check if both patches were ok togethe

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-10-06 Thread Anselmo L. S. Melo
> On 2010-10-01 17:21:28, Aaron Seigo wrote: > > update to current trunk if needed, and let's get this in as well. > > Anselmo L. S. Melo wrote: > @agateau: I've updated this patch to current trunk [1] - I updated it > when I wrote another patch [2], to check if both patches were ok togethe

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-10-05 Thread Aurélien Gâteau
> On 2010-10-01 17:21:28, Aaron Seigo wrote: > > update to current trunk if needed, and let's get this in as well. > > Anselmo L. S. Melo wrote: > @agateau: I've updated this patch to current trunk [1] - I updated it > when I wrote another patch [2], to check if both patches were ok togethe

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-10-02 Thread Anselmo L. S. Melo
> On 2010-10-01 17:21:28, Aaron Seigo wrote: > > update to current trunk if needed, and let's get this in as well. @agateau: I've updated this patch to current trunk [1] - I updated it when I wrote another patch [2], to check if both patches were ok together. Now it is an updated version on top

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-10-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4676/#review7930 --- Ship it! update to current trunk if needed, and let's get this in

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-09-27 Thread Anselmo Melo
> On 2010-09-24 10:43:08, Beat Wolf wrote: > > what is the status of this patch? > > Aurélien Gâteau wrote: > I need to ping someone so that it gets reviewed. I like this idea because it cleans the interface, specially in the vertical orientation. The patch need to be updated due to recent

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-09-24 Thread Aurélien Gâteau
> On 2010-09-24 10:43:08, Beat Wolf wrote: > > what is the status of this patch? I need to ping someone so that it gets reviewed. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-09-24 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4676/#review7753 --- what is the status of this patch? - Beat On 2010-08-04 21:02:11

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-08-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4676/ --- (Updated 2010-08-04 21:02:11.815343) Review request for Plasma. Changes --

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-07-20 Thread Aaron Seigo
> On 2010-07-19 21:33:59, Aaron Seigo wrote: > > i love the amount of red in this one :) > > > > only comment i have is that if the close button were moved into > > FilteringWidget itself, and a "closeClicked()" signal added to it, then the > > somewhat nasty static_cast to assign filteringLay

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-07-20 Thread Aurélien Gâteau
> On 2010-07-19 21:33:59, Aaron Seigo wrote: > > i love the amount of red in this one :) > > > > only comment i have is that if the close button were moved into > > FilteringWidget itself, and a "closeClicked()" signal added to it, then the > > somewhat nasty static_cast to assign filteringLay

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-07-19 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4676/#review6644 --- i love the amount of red in this one :) only comment i have is that i

Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-07-17 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4676/ --- Review request for Plasma. Summary --- Make AbstractIconList inherit from P