Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- Review request for Plasma. Description --- the upower

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22303 --- Ship it! Ship It! - Sebastian Kügler On Nov. 21, 2012,

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22317 --- Add Dario Freddi as reviewer and wait until he gives the ship

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:21 p.m.) Review request for Plasma and Dario

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22330 --- Now that I think about it, ltinkl can review this as well ! -

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/ --- (Updated Nov. 21, 2012, 5:43 p.m.) Review request for Plasma, Dario

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22338 --- Ship it! Ship It! - Dario Freddi On Nov. 21, 2012, 5:43

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22339 --- But why does the battery plasmoid always set the old

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22342 --- This review has been submitted with commit

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107398/#review22343 --- This review has been submitted with commit

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
On Nov. 21, 2012, 7:07 p.m., Kai Uwe Broulik wrote: But why does the battery plasmoid always set the old brightness? Now it knows the current brightness and sets it itself to the right value but still aren't these calls not needed and thus a bug also in the plasmoid? the brightness