Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/#review14116 --- This review has been submitted with commit

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-22 Thread Aaron J. Seigo
On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: Ehm, sorry for nitpicking but why is shipping allowed? It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing... There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Mark Gaiser
On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: Ehm, sorry for nitpicking but why is shipping allowed? It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing... There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/ --- (Updated May 21, 2012, 6:46 p.m.) Review request for Plasma. Changes

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Greg T
On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: Ehm, sorry for nitpicking but why is shipping allowed? It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing... There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Mark Gaiser
On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: Ehm, sorry for nitpicking but why is shipping allowed? It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing... There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/#review13997 --- Ship it! looks good - Marco Martin On May 15, 2012, 7:02

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/#review13998 --- You need to update Message.sh, it won't know to extract i18n

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/#review13999 --- right, forgot about that ;) yes, messages.sh has to be added

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-20 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/#review14005 --- Ehm, sorry for nitpicking but why is shipping allowed? It

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-20 Thread David Edmundson
On May 20, 2012, 10:24 p.m., Mark Gaiser wrote: Ehm, sorry for nitpicking but why is shipping allowed? It (probably) can't be closed by pressing CTRL+Q and the glow hover is missing... There is an import to import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets which seems

Review Request: qml port of showActivityManager (it's just an icon)

2012-05-15 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/ --- Review request for Plasma. Description --- Hello, I've played around