Re: Review Request: use portable KDiskFreeSpaceInfo for free space calculation

2010-06-07 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4241/#review6009 --- Christopher Blauvelt's reply:

Review Request: use portable KDiskFreeSpaceInfo for free space calculation

2010-06-06 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4241/ --- Review request for Plasma and Christopher Blauvelt. Summary --- Currently,

Re: Review Request: use portable KDiskFreeSpaceInfo for free space calculation

2010-06-06 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4241/ --- (Updated 2010-06-06 13:15:14.345121) Review request for Plasma and Christopher

Re: Review Request: use portable KDiskFreeSpaceInfo for free space calculation

2010-06-06 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4241/#review6000 --- Ship it! Can't imagine anything saner than this. Of course last word

Re: Review Request: use portable KDiskFreeSpaceInfo for free space calculation

2010-06-06 Thread Christopher Blauvelt
Seems fine to me. I think the reason we used unix specific libraries originally was we did not plan on supporting plasma on other OSs. Clearly that's no longer the case so this makes sense. On Sun, Jun 6, 2010 at 2:08 PM, Alessandro Diaferia alediafe...@gmail.comwrote: