Re: Review Request: use window role to detect the dashboard

2012-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15436 --- This review has been submitted with commit

Re: Review Request: use window role to detect the dashboard

2012-07-04 Thread Andreas Demmer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15359 --- Ship it! Ship It! - Andreas Demmer On June 28, 2012, 7:42

Re: Review Request: use window role to detect the dashboard

2012-07-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15360 --- Ship it! from my side ok, maybe wait a day whether a plasma

Re: Review Request: use window role to detect the dashboard

2012-07-04 Thread Andreas Demmer
On July 4, 2012, 7:57 a.m., Andreas Demmer wrote: Ship It! I missed that windowRole would be a much better distinction than windowClass is when I initially implemented this effect. Your patch definitely makes sense, so ship it! - Andreas

Re: Review Request: use window role to detect the dashboard

2012-07-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15330 --- Ship it! I really would like to have a proper solution by

Re: Review Request: use window role to detect the dashboard

2012-07-03 Thread Thomas Lübking
On July 3, 2012, 8:30 a.m., Martin Gräßlin wrote: plasma/desktop/shell/dashboardview.cpp, line 99 http://git.reviewboard.kde.org/r/105382/diff/1/?file=70604#file70604line99 maybe plasma-dashboard? I thought to stress that this is the kind of dashboard that carries plasmoids, but i

Review Request: use window role to detect the dashboard

2012-06-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/ --- Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.

Re: Review Request: use window role to detect the dashboard

2012-06-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105382/#review15245 --- Nice catch! I do not have a printer that supports reporting

Re: Review Request: use window role to detect the dashboard

2012-06-28 Thread Kai Uwe Broulik
On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote: Nice catch! I do not have a printer that supports reporting ink levels, so I cannot test whether it causes unexpected behavior, but I don’t think so. Daniel should look over this anyway. Thanks for the patch! :) Sorry, Wrong