---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2026/#review2901
---
/trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2026/
---
(Updated 2009-11-03 19:51:12.510139)
Review request for kdelibs, Plasma and
On 2009-11-03 17:00:51, Will Stephenson wrote:
/trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.cpp, line 44
http://reviewboard.kde.org/r/2026/diff/2/?file=13614#file13614line44
By convention, public member variables of pimpl classes are not names
with m_ prefixes -
On 2009-11-01 08:46:19, Will Stephenson wrote:
I don't see a reason for the first leak you highlight in your code. You
should create the url using QLatin1String as this saves QString having to
guess the encoding -see
http://labs.trolltech.com/blogs/2008/04/28/string-theory/ for
On Monday 02 November 2009 21:46:12 Aaron Seigo wrote:
I have removed the QObject inheritance in my current working copy.
the Ions are QObjects primarily for memory management; since the Ion
plugins tend to have signal/slot connections they'd end up subclassing
QObject and so it just made
On 2009-11-01 08:46:19, Will Stephenson wrote:
I don't see a reason for the first leak you highlight in your code. You
should create the url using QLatin1String as this saves QString having to
guess the encoding -see
http://labs.trolltech.com/blogs/2008/04/28/string-theory/ for
On 2009-10-31 18:48:39, Thilo-Alexander Ginkel wrote:
Oh, and personally I would use some kind of shared pointer for the
WeatherData::Forecast[Period|INFO]* objects. But this is just something
personal. I try to avoid memory I have to delete explicitly these days.
When I search for
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2026/#review2882
---
I don't see a reason for the first leak you highlight in your code.
On 2009-10-31 18:48:39, Armin Berres wrote:
/trunk/kdereview/plasma/dataengines/weather/ions/ion_wettercom.h, line 146
http://reviewboard.kde.org/r/2026/diff/1/?file=13579#file13579line146
Nitpicking: What about fetchForecast instead of getForecast? When I
looked at the header a
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2026/
---
(Updated 2009-11-01 18:31:18.178318)
Review request for kdelibs, Plasma and
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2026/
---
Review request for kdelibs, Plasma and Shawn Starr.
Summary
---
This
11 matches
Mail list logo
